? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 May 2022

Pull Request for Issue #37864 .

Summary of Changes

add a margin around the tags so that the focus ring is displayed correctly

Testing Instructions

This is a css change so either use a pre-built package or npm run build:css

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

n/a

avatar brianteeman brianteeman - open - 24 May 2022
avatar brianteeman brianteeman - change - 24 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2022
Category Repository NPM Change
avatar chmst chmst - test_item - 24 May 2022 - Tested successfully
avatar chmst
chmst - comment - 24 May 2022

I have tested this item successfully on 3fa7b26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877.

avatar Kostelano Kostelano - test_item - 24 May 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 24 May 2022

I have tested this item successfully on 3fa7b26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877.

avatar alikon alikon - change - 24 May 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 24 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37877.

avatar richard67 richard67 - change - 26 May 2022
Labels Added: ? ?
avatar richard67
richard67 - comment - 26 May 2022

@brianteeman After I had updated your branch to make the npm step pass in drone, the scss code style check fails in drone: https://ci.joomla.org/joomla/joomla-cms/54621/1/24 .

avatar brianteeman
brianteeman - comment - 26 May 2022

Thanks for fixing drone. I thought it might have been better as short hand but couldnt remember if we just left that to the compiler..

avatar brianteeman brianteeman - change - 26 May 2022
Labels Added: NPM Resource Changed
avatar sandewt
sandewt - comment - 26 May 2022

Thanks

avatar Quy Quy - change - 28 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-28 20:28:16
Closed_By Quy
avatar Quy Quy - close - 28 May 2022
avatar Quy Quy - merge - 28 May 2022
avatar Quy
Quy - comment - 28 May 2022

Thanks

Add a Comment

Login with GitHub to post a comment