Feeling Lucky
?
[#37873] - [4] Fix for 37859. mod_feed. inline style and nonces.
- Closed
- 19 Jun 2022
- Medium
- Build: 4.1-dev
- # 37873
- Diff
- ReLater:patch-4
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-24 10:38:46 |
| Closed_By | ⇒ | ReLater | |
| Labels |
Added:
?
|
||
HLeithner
- | Status | Closed | ⇒ | New |
| Closed_Date | 2022-05-24 10:38:46 | ⇒ | |
| Closed_By | ReLater | ⇒ |
| Status | New | ⇒ | Pending |
drmenzelit
- comment
- 3 Jun 2022
Since modules can be loaded multiple times on a page (on a position and via loadmodule on an article) we should not have an id on the module. Please have a look a this very long discussion: #30716
I know, mod_custom has still an id in the code, but that should be fixed too..
brianteeman
- comment
- 3 Jun 2022
@drmenzelit you have misunderstood that discussion
drmenzelit
- comment
- 3 Jun 2022
The point at the end is that if the module have an id and you are loading the module twice, you will have duplicate ids in the code
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-19 17:46:09 |
| Closed_By | ⇒ | ReLater |
laoneo
- comment
- 19 Jun 2022
Why did you close?
ReLater
- comment
- 19 Jun 2022
Because it was open for 2 weeks now and I couldn't see any PR to my branch or a suggestion to add the wanted changes by click.
I have tested this item✅ successfully on ad83e0b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37873.