? ? Pending

User tests: Successful: Unsuccessful:

avatar cyrezdev
cyrezdev
21 May 2022

Improve Pull Request #37819 for Issue #37772

Summary of Changes

Following @nikosdion comment #35610 (comment) and #35610 (comment)

This PR removes the ability to set an attribute inlineHelp to the form field xml element.

I agree with @nikosdion on his statement, and so i have improved and simplified here my previous PR to only focus on fixing issue with hidden descriptions if no inlinehelp toggle button integrated.

Testing Instructions

Same as for previous PR #37819

  • Check if descriptions are hidden by default in com_config and com_content options.
  • Check if descriptions are shown by default everywhere else (where toggle button is not integrated) : component options, item edition, plugins manager... and in third-party extensions not integrating the toggle button.
  • Toggle button works as expected in com_config and com_content
avatar cyrezdev cyrezdev - open - 21 May 2022
avatar cyrezdev cyrezdev - change - 21 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2022
Category Libraries
avatar cyrezdev cyrezdev - change - 21 May 2022
The description was changed
avatar cyrezdev cyrezdev - edited - 21 May 2022
avatar cyrezdev cyrezdev - change - 21 May 2022
The description was changed
avatar cyrezdev cyrezdev - edited - 21 May 2022
avatar Kostelano Kostelano - test_item - 22 May 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 22 May 2022

I have tested this item successfully on 12d9076

Everything still works well.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849.

avatar nikosdion
nikosdion - comment - 23 May 2022

I approve of this change. Having been the one asking for it I am not sure if it's proper for me to provide a test? If so, let me know and I will.

avatar conseilgouz conseilgouz - test_item - 28 May 2022 - Tested successfully
avatar conseilgouz
conseilgouz - comment - 28 May 2022

I have tested this item successfully on 12d9076


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849.

avatar alikon alikon - change - 28 May 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37849.

avatar Quy Quy - change - 28 May 2022
Labels Added: ? ?
avatar laoneo laoneo - close - 3 Jun 2022
avatar laoneo laoneo - merge - 3 Jun 2022
avatar laoneo laoneo - change - 3 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-03 09:34:57
Closed_By laoneo
avatar laoneo
laoneo - comment - 3 Jun 2022

Thanks!

Add a Comment

Login with GitHub to post a comment