User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) adds removal of .bowerrc and bower.json files from 3rd party libraries in general and of the "build", "demo", "docs" and "tests" folder or the composer dependency "maximebf/debugbar" in particular to the build script "build/build.php" so that these files and folders which are not needed on a J4 installation will not be included in the full installation or update packages.
Furthermore it adds the mentioned files and all files in the mentioned folders to script.php to the list of files to be removed on update and the folders to the list of folders to be removed on update.
The reason for this is that again - like it was before with another dependency and fixed with my PR #37458 - these developer files have been released with the 4.1.3 release in the installation package, while they are not in the 4.1.4-dev nightly builds and also not in packages which I build here locally on Linux.
Code review by someone who knows the build process should be enough this time.
Ping @wilsonge .
I am not really willing to write again such detailed testing instructions like I did for my PR #37458 .
Depending on your environment (OS), there might or there might not be all these files and folders in the full installation package when you build it locally.
None of these files and folders is in the full installation package when you build it locally, as it is with the nightly builds.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin Repository |
Labels |
Added:
?
|
Yep, thx, I'm aware of it
Keep in mind, once the debug bar dependency will be reverted back to the official release, then these changes can probably be reverted. This was introduced with #37488 and the open issue is #37274.
@laoneo The change in build.php maybe, but the change in script.php will still be necessary if we want to clean up these files when updating from 4.1.3.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-20 21:22:09 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
Release Blocker
|
Thx
//cc @bembelimen