? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
18 May 2022

Pull Request for Issue # .

Summary of Changes

With the last merge from 4.1-dev to 4.2-dev, PR #37714 was not completely merged up.

The files which had been moved from the list of folders to the list of files have been added in the list of files but not removed in the list of folders.

Furthermore, with this commit, another files was added to the list of folders and not the list of files in 4.2-dev: 61c6f1f

This PR here corrects these mistakes and fixes code style so that the last element in an array is followed by a comma, which is one of our code style rules.

In addition, the version comment "// From 4.1.1 to 4.2.0" is changed to "// From 4.1 to 4.2.0" because that section does not depend on the patch version of 4.1, it applies to any 4.1.

Testing Instructions

Code review should be enough.

Actual result BEFORE applying this Pull Request

Files are in the list of folders to be deleted, and '/administrator/components/com_users/src/Field/PrimaryauthprovidersField.php' appears in both lists of files and folders.

Expected result AFTER applying this Pull Request

Files are in the list of files where they should be.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 18 May 2022
avatar richard67 richard67 - change - 18 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2022
Category Administration com_admin
avatar roland-d roland-d - close - 18 May 2022
avatar roland-d roland-d - merge - 18 May 2022
avatar roland-d roland-d - change - 18 May 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-18 18:30:56
Closed_By roland-d
Labels Added: ?
avatar roland-d
roland-d - comment - 18 May 2022

Thank you @richard67

Add a Comment

Login with GitHub to post a comment