[#37819] - FIX #37772 - inlineHelp Toggle Button control
- Fixed in Code Base
- 18 May 2022
- Medium
- Build: 4.1-dev
- # 37819
- Diff
- cyrezdev:patch-46
User tests: Successful: Unsuccessful:
Pull Request for Issue #37772 .
Summary of Changes
- Add inlineHelp option to formField
- Control if inlineHelp toggle button is enabled for the current form
- Add 'hide-aware-inline-help d-none' if enabled, as default description class
You can know add an xml form field attribute "inlinehelp" to use or not the toggling of description field by field (values boolean true/false). Eg. inlinehelp="false" applied on one field, will keep always the description shown even if click on description toggle.
UPDATE: see PR #37849 removing the inlinehelp attribute availability for form field xml element.
Testing Instructions
- Check if descriptions are hidden by default in com_config and com_content options.
- Check if descriptions are shown by default everywhere else (where toggle button is not integrated) : component options, item edition, plugins manager... and in third-party extensions not integrating the toggle button.
- Toggle button works as expected in com_config and com_content
Actual result BEFORE applying this Pull Request
- Description is hidden on all places where inlinehelp toggle button is not integrated. Almost everywhere in 4.1.3.
Expected result AFTER applying this Pull Request
- Description is shown if no inlinehelp toggle button.
Documentation Changes Required
inline help global documentation, and form field attribute inlinehelp.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Layout Libraries |
I have tested this item
I checked components, modules, plugins. Everything works as stated. Thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37819.
I know Github has a "tested with success or not" button, but each time a search it i can't found it easy... can you point me to the button, please?
@Valc That button is not on GitHub, it is in our issue tracker, e.g. for this PR on https://issues.joomla.org/tracker/joomla-cms/37819 . Use the blue “Test this” button at the top left corner, then select the right test result and the submit.
| Labels |
Added:
?
|
||
I have tested this item
Tested following the test instructions. Com_config, com_content and some other core components and an own plugin work as described. Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37819.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-18 19:14:20 |
| Closed_By | ⇒ | bembelimen |
Nice solution, thx
Hi :)
After test your patch all is working as you explain: the views with 'Options' button that have not an "inlinehelp" are displaying the desc text.
At com_content pressing the "inlinehelp" is also working.
But at "com_config" >> "Options" with an "inlinehelp" button is failing: pressing it has no effect.
I know Github has a "tested with success or not" button, but each time a search it i can't found it easy... can you point me to the button, please?
For me is not working at all as is expected due at com_config is failing toggle it.
If i understand right this patch is not focused to solve the issue about editing modules than also lost the desc text: this one is also an
EDITED
Forgot it! at modules edition is also working like a charm! XD
Other site module:
When my modules have selected "Hide Legends" only the Desc text is displayed:
And now all is working rightly again.
Regards, Valc.