[#37818] - [4.1] AdminController - Add context if any, to redirect URL
Pending
User tests: Successful: Unsuccessful:
Pull Request to fix missing context for com_fields when doing actions like publishing or unpublishing Field or Field Group items.
Summary of Changes
In the Custom Field Groups and Custom Fields of Content & Users, the left menu closed after doing an action (like publish or unbublish) on a Custom Field Group Item or Custom Field Item.
Field Groups menu closes when doing actions
- In back-end go to: Content > Field Groups
- Create a Field group and Save & Close
- Notice the URL:
/administrator/index.php?option=com_fields&view=groups&context=com_content.article - Unpublish the Group
- Notice the new URL and the closed Menu:
/administrator/index.php?option=com_fields&view=groups
The Context is not passed through, and the menu has been closed.
The same issue happens in other places with other Custom Fields too.
Testing Instructions
Go to each of the following menu items and publish or unpublish an item:
- Content > Field Groups /administrator/index.php?option=com_fields&view=groups&context=com_content.article
- Content > Fields /administrator/index.php?option=com_fields&view=fields&context=com_content.article
- Users > Field Groups /administrator/index.php?option=com_fields&view=groups&context=com_users.user
- Users > Fields /administrator/index.php?option=com_fields&view=fields&context=com_users.user
/administrator/index.php?option=com_fields&view=fields&context=com_content.article
Actual result BEFORE applying this Pull Request
After doing a publish or unpublish action in com_fields, the menu on the left closes because the URL is missing the &context=[component][view]
Expected result AFTER applying this Pull Request
After doing a publish or unpublish action in com_fields, the menu on the left remains open because the right context &context=[component][view] is passed through via the URL.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-4.1-dev
|
||
@pe7er The propose change does not look right to me. For this, you should modify code in Fields and Groups controllers of com_fields instead. Just add getRedirectToListAppend method to the two controllers with the below code should solve the issue:
protected function getRedirectToListAppend()
{
$context = $this->input->getString('context');
if ($context)
{
return '&context=' . $context;
}
}
This pull requests has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
Updates Requested
psr12
|
||
Hi @pe7er
Look like you are too busy and do not have time to make the suggested change as I commented #37818 (comment) . So I made the PR #39926 to replace this one to have this issue fixed and close this PR. Hope that's fine for you. If you still want to finish this PR, please let me know. I will close mine and re-open yours. Thanks !
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-24 10:40:48 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
PR-4.2-dev
Removed: PR-4.1-dev psr12 |
||
also see #34067