? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
12 May 2022

Pull Request for Issue #37778.

Summary of Changes

Make small change to draggable script to solve the re-ordering nested items (menu items, categories...) as reported #37778 .

Testing Instructions

  • Use Joomla 4.1.3 (or 4.1 nightly build)
  • Look at #37778 , confirm the issue
  • Upgrade your site to the download package generated for this PR.
  • Confirm the issue fixed.
  • Please try to re-order other items like articles, modules, categories and make sure the ordering are saved properly, too
avatar joomdonation joomdonation - open - 12 May 2022
avatar joomdonation joomdonation - change - 12 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2022
Category JavaScript Repository NPM Change
avatar joomdonation
joomdonation - comment - 12 May 2022

For some reasons, the upgrade packages generated for this PR does not contains change for the JS files. So to test this PR, please get the attached zip file, unzip it, and upload the received files to media/system/js folder on your Joomla installation to have the change applied.
draggable.zip

avatar fredhob
fredhob - comment - 12 May 2022

Hi,

I replace files with yours and clean browser cache but the issue stay.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37781.

avatar joomdonation
joomdonation - comment - 12 May 2022

@fredhob Thanks for trying. I don't know why it is not working for you because on my local installation, it worked OK for me.

avatar brianteeman
brianteeman - comment - 12 May 2022

I have tested this item successfully on 4879f66

patched my local branch and rebuilt the js

The menu sort and re-order now works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37781.

avatar brianteeman brianteeman - test_item - 12 May 2022 - Tested successfully
avatar fredhob
fredhob - comment - 12 May 2022

Yes it's work for me now too, it's weird but thanks a lot!

avatar joomdonation
joomdonation - comment - 12 May 2022

@fredhob The only reason is that the js files were cached and it took sometime for your browser to load the updated files. I'm glad it works for you now.

avatar Quy Quy - alter_testresult - 12 May 2022 - fredhob: Tested successfully
avatar Quy Quy - change - 12 May 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 12 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37781.

avatar laoneo laoneo - change - 12 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-12 14:43:17
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 12 May 2022
avatar laoneo laoneo - merge - 12 May 2022
avatar laoneo
laoneo - comment - 12 May 2022

Thanks!

avatar Sandvelder
Sandvelder - comment - 14 May 2022

Hi, I copied the contents of the ZIP file to media/system/js but to no avail. Should I do anything other than copying the files in that directory?
Regards,


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37781.

avatar joomdonation
joomdonation - comment - 14 May 2022

@Sandvelder After copying the files, please clear browser cache and the issue should be sorted.

avatar Sandvelder
Sandvelder - comment - 14 May 2022

Thank you, it worked!

Add a Comment

Login with GitHub to post a comment