? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar vorayash
vorayash
3 May 2022

Pull Request for Issue #37593

Summary of Changes

To select chevrons, 'i' was used instead of 'span' because of that it was not selecting anything.

Testing Instructions

Go to Modules >> any module >> Menu Assignment tab >> Only on the pages selected
Click on one or two menus to expand them
The chevrons on the left change from .icon-chevron-right to .icon-chevron-down correctly
Now click on >> Expand the Menu Subtrees >> None

Actual result BEFORE applying this Pull Request

The chevrons do not change so some are incorrect

Expected result AFTER applying this Pull Request

The chevrons change correctly.

avatar vorayash vorayash - open - 3 May 2022
avatar vorayash vorayash - change - 3 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2022
Category JavaScript Repository NPM Change
avatar brianteeman
brianteeman - comment - 3 May 2022

I have tested this item successfully on c059f3f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37734.

avatar brianteeman brianteeman - test_item - 3 May 2022 - Tested successfully
avatar SumCompanyInc
SumCompanyInc - comment - 4 May 2022

I have tested this item successfully on c059f3f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37734.

avatar SumCompanyInc SumCompanyInc - test_item - 4 May 2022 - Tested successfully
avatar saraheagle
saraheagle - comment - 4 May 2022

Fab, thank you very much ?

avatar chmst chmst - change - 4 May 2022
Status Pending Ready to Commit
avatar chmst
chmst - comment - 4 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37734.

avatar laoneo laoneo - change - 13 May 2022
Labels Added: ? NPM Resource Changed ?
avatar laoneo laoneo - change - 13 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-13 13:13:13
Closed_By laoneo
avatar laoneo laoneo - close - 13 May 2022
avatar laoneo laoneo - merge - 13 May 2022
avatar laoneo
laoneo - comment - 13 May 2022

Thanks!

Add a Comment

Login with GitHub to post a comment