? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
1 May 2022

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the lists of files and folders to be deleted on update by script.php for the upcoming 4.1.3 release - details see below - and adds file "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" from the 3.10-dev branch.

The "CssIdentifierSubstringRule.php" file has been added due to a security patch with commit 44b7b89 .

In Joomla 4.x this file is not really needed because the same security fix uses the "CssIdentifierRule" from this file https://github.com/joomla/joomla-cms/blob/4.1-dev/libraries/src/Form/Rule/CssIdentifierRule.php , which is more strict.

But it makes sense to keep that file, and so I add it with this PR. It can be used by 3rd party developers to validate form fields for parts of CSS identifiers like we had them in past (J3) in the core with the "CSS class suffix" fields, while the "CssIdentifierRule" only make sense for validating complete CSS identifiers.

In detail following changes are made on the lists of files and folders to be deleted on update by script.php:

  • Move file "/administrator/components/com_users/src/Field/PrimaryauthprovidersField.php" from the "$folders" to the "$files" array. It was added by mistake to the "$folders" array with PR #37415 . Possibly my mistake with my code suggestion for that PR.
  • Add missing leading slash to file "/libraries/vendor/webmozart/assert/.php_cs" - the missing "/" was my mistake from PR #37458 .

There have not been detected any files or folders to be added to the lists in script.php by my tool.

Testing Instructions

Code review should be enough.

Actual result BEFORE applying this Pull Request

File "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" doesn't exist.

In file "administrator/components/com_admin/script.php":

  • File "/administrator/components/com_users/src/Field/PrimaryauthprovidersField.php" is at the end of the "$folders" array in section "// From 4.1.1 to 4.1.2".
  • File "libraries/vendor/webmozart/assert/.php_cs" - mind the missing leading "/" - is at the end of the "$files" array in section "// From 4.1.2 to 4.1.3".

Expected result AFTER applying this Pull Request

File "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" exists. It is equal to https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/src/Form/Rule/CssIdentifierSubstringRule.php except of the changed copyright format at the top and the leading backslash of the "defined" statement.

In file "administrator/components/com_admin/script.php":

  • File "/administrator/components/com_users/src/Field/PrimaryauthprovidersField.php" is at the end of the "$files" array in section "// From 4.1.1 to 4.1.2".
  • The missing leading "/" has been added to file "/libraries/vendor/webmozart/assert/.php_cs" in section "// From 4.1.2 to 4.1.3".

Documentation Changes Required

None.

avatar richard67 richard67 - open - 1 May 2022
avatar richard67 richard67 - change - 1 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2022
Category Administration com_admin
avatar richard67 richard67 - change - 1 May 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2022
Category Administration com_admin Administration com_admin Libraries
avatar richard67 richard67 - change - 1 May 2022
Title
[4.1] [WiP] Update deleted files list in script.php for upcoming 4.1.3 release
[4.1] [WiP] Update deleted files list in script.php for upcoming 4.1.3 release and add missing form validation rule from 3.10
avatar richard67 richard67 - edited - 1 May 2022
avatar richard67 richard67 - change - 1 May 2022
The description was changed
avatar richard67 richard67 - edited - 1 May 2022
avatar richard67 richard67 - change - 1 May 2022
Title
[4.1] [WiP] Update deleted files list in script.php for upcoming 4.1.3 release and add missing form validation rule from 3.10
[4.1] Update deleted files list in script.php for upcoming 4.1.3 release and add missing form validation rule from 3.10
avatar richard67 richard67 - edited - 1 May 2022
avatar richard67 richard67 - change - 1 May 2022
The description was changed
avatar richard67 richard67 - edited - 1 May 2022
avatar richard67 richard67 - change - 1 May 2022
The description was changed
avatar richard67 richard67 - edited - 1 May 2022
avatar richard67 richard67 - change - 1 May 2022
The description was changed
avatar richard67 richard67 - edited - 1 May 2022
avatar richard67 richard67 - change - 1 May 2022
The description was changed
avatar richard67 richard67 - edited - 1 May 2022
avatar richard67 richard67 - change - 1 May 2022
The description was changed
avatar richard67 richard67 - edited - 1 May 2022
avatar bembelimen bembelimen - close - 1 May 2022
avatar bembelimen bembelimen - merge - 1 May 2022
avatar bembelimen bembelimen - change - 1 May 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-01 14:39:28
Closed_By bembelimen
avatar bembelimen
bembelimen - comment - 1 May 2022

thx

Add a Comment

Login with GitHub to post a comment