User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) updates the lists of files and folders to be deleted on update by script.php for the upcoming 4.1.3 release - details see below - and adds file "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" from the 3.10-dev branch.
The "CssIdentifierSubstringRule.php" file has been added due to a security patch with commit 44b7b89 .
In Joomla 4.x this file is not really needed because the same security fix uses the "CssIdentifierRule" from this file https://github.com/joomla/joomla-cms/blob/4.1-dev/libraries/src/Form/Rule/CssIdentifierRule.php , which is more strict.
But it makes sense to keep that file, and so I add it with this PR. It can be used by 3rd party developers to validate form fields for parts of CSS identifiers like we had them in past (J3) in the core with the "CSS class suffix" fields, while the "CssIdentifierRule" only make sense for validating complete CSS identifiers.
In detail following changes are made on the lists of files and folders to be deleted on update by script.php:
There have not been detected any files or folders to be added to the lists in script.php by my tool.
Code review should be enough.
File "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" doesn't exist.
In file "administrator/components/com_admin/script.php":
File "libraries/src/Form/Rule/CssIdentifierSubstringRule.php" exists. It is equal to https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/src/Form/Rule/CssIdentifierSubstringRule.php except of the changed copyright format at the top and the leading backslash of the "defined" statement.
In file "administrator/components/com_admin/script.php":
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin |
Labels |
Added:
?
|
Category | Administration com_admin | ⇒ | Administration com_admin Libraries |
Title |
|
Title |
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-01 14:39:28 |
Closed_By | ⇒ | bembelimen |
thx