@coolcat-creations I think the issue in the logo when opening in microsoft edge , not in chrome because in chrome there is no any direct features (system default, light, dark) like microsoft edge and github logo is also not changing with changing the theme , but when applying the patch it's working fine for microsoft edge but the logo is coming, different from the expected result.
This logo is coming after applying the patch and with the dark theme of microsoft edge.

Thanks :)

@coolcat-creations the bug seems that is already fixed in chrome https://bugs.chromium.org/p/chromium/issues/detail?id=1311553#c12

Also this PR breaks badly B/C for people that have created their own favicons, so in that sense it's wrong

Did you check in chrome ? Because I did and it seems to work for normal displayed svg on a website) but not for svg used as favicon.

Did you check in chrome ?

Yes, Chrome Canary 103 works for me

@dgrammatiko there is no Version 103 available for Mac... And the issue is still there. But if you are saying thats purely a chrome issue and even if this PR fixes it - we have to close both: issue and PR

@pritam825 your issue is bit unrelated to this one. Your Browser does not support svg at all and so it shows the ico format.

@coolcat-creations ok got it mam, and my According pr and issue both should be closed, because if we will used dark theme in chrome, GitHub logo is also not changing as we are comparing to GitHub, Thanks :)

My github logo is changing, my Joomla Logo not.

Funny is that github delivers a separate dark icon like I proposed here. :-)

there is no Version 103 available for Mac.

Nightly build for developers: https://www.google.com/chrome/canary/

And the issue is still there

You have to test the canary version

But if you are saying thats purely a chrome issue and even if this PR fixes it

It is a Chrome issue, Safari and Firefox obey the CSS of the SVG and that PR seems to solve the the issue. Also, again, this PR is introducing a B/C break on both the templates...

How comes you think it's a bc break? Its a new file and did not change an existing file.

How comes you think it's a bc break? Its a new file and did not change an existing file.

So, if I have created an svg file for both cassiopeia and atum that have css to control the dark/light theme then that file will be available only on the light theme and on dark theme I will get the standard joomla logo. In other words you broke existing functionality.

Also please understand that this IS a chrome issue and THEY have to fix it. Patching Joomla is not the right path

It's not a B/C break per our definition (Design/HTML markup is explicitely excluded). Just saying ?

I have tested this item ✅ successfully on 768793c

Confirmed issue on windows with chrome Version 102.0.5005.63 (Official Build) (64-bit)

In Windows Firefox 101.0.1 (not dark mode), it displays the white icon.
The first tab is from the prebuilt packpage of this PR.
The second tab is from the nightly build.

This pull requests has automatically rebased to 4.2-dev.

This pull requests has been automatically converted to the PSR-12 coding standard.