[#37699] - [4.1] inline-help hidden by default
- Fixed in Code Base
- 1 May 2022
- Medium
- Build: 4.1-dev
- # 37699
- Diff
- brianteeman:inline_help
User tests: Successful: Unsuccessful:
Pull Request for Issue #37697 .
Summary of Changes
The intention of this functionality is for the description to be hidden by default and its visibility toggled from the button.
The problem is that the default hidden state was added by javascript after the page has loaded and this resulted in a flash of text being displayed.
This PR changes the code so that the d-none class is present by default in the markup
Testing Instructions
This includes a javascript chanage so will need npm run build:js or one of the prebuilt packages
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End com_config Layout |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37699.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37699.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37699.
| Labels |
Added:
?
Maintainers Checked
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-01 11:28:48 |
| Closed_By | ⇒ | bembelimen |
Thx
thanks
The PR has broken the display of descriptions everywhere as always hidden by default, and because the toggle button is integrated yet only in com_config and com_content options, can't be set by default on d-none in the markup.
Not only config pages are affected, but all edition and third-party extensions.
So, i would go to revert this PR until we find a better solution to not have the "flash" of description text.
I have tested this item✅ successfully on 4c41479
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37699.