? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar hirakei1203
hirakei1203
29 Apr 2022

Pull Request for Issue #37467.

Summary of Changes

In the Frontend, "Select a Menu Item" Modal, Menu Editing Page,
the position of tooltip was moved to left to just below the tooltip target element.

Testing Instructions

Log in frontend and check the tooltip position.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image_fix_37467_after_khirano

This is my first PR to this Project!:) Thanks.

avatar hirakei1203 hirakei1203 - open - 29 Apr 2022
avatar hirakei1203 hirakei1203 - change - 29 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2022
Category Repository NPM Change
avatar hirakei1203 hirakei1203 - change - 29 Apr 2022
Labels Added: NPM Resource Changed ?
avatar Kostelano
Kostelano - comment - 29 Apr 2022

I have tested this item successfully on d9d2b21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37695.

avatar Kostelano Kostelano - test_item - 29 Apr 2022 - Tested successfully
avatar SumCompanyInc
SumCompanyInc - comment - 29 Apr 2022

I have tested this item successfully on d9d2b21

i wasnt able to use the patch tester, but i was able to update using the download with patch, and it got the tooltip icon much more closer. but it wasnt centered, but that just nitpicking, it certainly much better than across the screen. great job! thanks! image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37695.

avatar SumCompanyInc SumCompanyInc - test_item - 29 Apr 2022 - Tested successfully
avatar chmst chmst - change - 29 Apr 2022
Status Pending Ready to Commit
avatar chmst
chmst - comment - 29 Apr 2022

RTC. Thank you @hirakei1203!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37695.

avatar bembelimen bembelimen - change - 30 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-30 03:00:41
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 30 Apr 2022
avatar bembelimen bembelimen - merge - 30 Apr 2022
avatar bembelimen
bembelimen - comment - 30 Apr 2022

Thx

Add a Comment

Login with GitHub to post a comment