? ? Maintainers Checked Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
29 Apr 2022

Pull Request to fix the Admin/Site filter in Modules

Summary of Changes

Testing Instructions

  • In J4 back-end go to: Content > Administrator Modules
  • Notice that the Admin/Site filter is set to "Administrator"
  • Select an Admin module from the list
  • Choose under "Actions" for "Duplicate"

modules-filter-instructions

Actual result BEFORE applying this Pull Request

  • After the Module got duplicated, the Admin/Site filter is wrongly set to "Site"
  • The list of Modules displays the Site Modules and not the Administrator Modules

modules-filter-before-pr

Expected result AFTER applying this Pull Request

  • After the Module got duplicated, the Admin/Site filter is set to "Administrator"
  • The list of Modules displays the Administrator Modules like expected

modules-filter-after

avatar pe7er pe7er - open - 29 Apr 2022
avatar pe7er pe7er - change - 29 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2022
Category Administration com_modules
avatar pe7er pe7er - change - 29 Apr 2022
Labels Added: ?
avatar JoeJoomla
JoeJoomla - comment - 29 Apr 2022

I have tested this item successfully on 76f5c41

I have tested this item successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37694.

avatar JoeJoomla JoeJoomla - test_item - 29 Apr 2022 - Tested successfully
avatar chmst
chmst - comment - 29 Apr 2022

I have tested this item successfully on 76f5c41


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37694.

avatar chmst chmst - test_item - 29 Apr 2022 - Tested successfully
avatar chmst chmst - change - 29 Apr 2022
Status Pending Ready to Commit
avatar chmst
chmst - comment - 29 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37694.

avatar bembelimen bembelimen - close - 30 Apr 2022
avatar bembelimen bembelimen - merge - 30 Apr 2022
avatar bembelimen bembelimen - change - 30 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-30 02:47:56
Closed_By bembelimen
Labels Added: ? Maintainers Checked
avatar bembelimen
bembelimen - comment - 30 Apr 2022

Thx

Add a Comment

Login with GitHub to post a comment