? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
25 Apr 2022

Pull Request for Issue # . Replaces #36945

Summary of Changes

  • Removes the readonly attribute from the input of Media Field so users could type freely
  • It doesn't fix the preview for EXTERNAL urls (out of scope)

Testing Instructions

  • Create a new article and add some title
  • go to the images tab
  • type (or copy paste) images/sampledata/cassiopeia/not-valid.jpg
  • save the form
  • type (or copy paste) images/sampledata/cassiopeia/nasa1-400.jpg
  • Save the form (observe that the image url has the # parts!!!!)
  • type (or copy paste) /images/sampledata/cassiopeia/nasa1-400.jpg
  • save the form (observe the URL)
  • type (or copy paste) any valid external URL
  • save the form

Screenshot 2022-04-25 at 16 31 44

Screenshot 2022-04-25 at 16 32 11

Screenshot 2022-04-25 at 16 32 22

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 25 Apr 2022
avatar dgrammatiko dgrammatiko - change - 25 Apr 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2022
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 25 Apr 2022
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2022
Category JavaScript Repository NPM Change JavaScript Repository NPM Change Layout
avatar dgrammatiko dgrammatiko - change - 25 Apr 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 25 Apr 2022
avatar dgrammatiko dgrammatiko - change - 25 Apr 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 25 Apr 2022
avatar coolcat-creations
coolcat-creations - comment - 25 Apr 2022

@dgrammatiko I tested the patch and typing is possible but it does not update the preview after typing in / pasting the desired path

  • the # are not added - should they be added with the patch? I am testing on localhost with the patchtester
avatar dgrammatiko
dgrammatiko - comment - 25 Apr 2022

did you read the description? Also what is the url you're entering?

I am testing on localhost with the patchtester

Yeah that won't work, try d/l the package at the end of this PR (GitHub)

avatar coolcat-creations
coolcat-creations - comment - 25 Apr 2022

Yes I read the description - maybe I misunderstood them or the issue is because i used patchtester. I will try with the prebuild package then. Thank you

avatar coolcat-creations
coolcat-creations - comment - 25 Apr 2022

I installed now the prebuilt package and it works mostly like expected.
Only mostly because I succeeded to break it like that, that now the not valid message appears despite I chosed an image in the modal. (Also after hitting save)

grafik

avatar dgrammatiko
dgrammatiko - comment - 25 Apr 2022

@coolcat-creations should be fine now

avatar coolcat-creations
coolcat-creations - comment - 25 Apr 2022

I have tested this item successfully on 048f033


type (or copy paste) images/sampledata/cassiopeia/not-valid.jpg - done works (Validation message displayed)

type (or copy paste) images/sampledata/cassiopeia/nasa1-400.jpg - done works (#parts added)

type (or copy paste) /images/sampledata/cassiopeia/nasa1-400.jpg - done works (#parts added)

type (or copy paste) any valid external URL - done and works (image previewed, no # parts added as expected)

Thank you very much!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.
avatar coolcat-creations coolcat-creations - test_item - 25 Apr 2022 - Tested successfully
avatar dgrammatiko dgrammatiko - change - 25 Apr 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 25 Apr 2022
avatar richard67
richard67 - comment - 25 Apr 2022

@coolcat-creations Could you test this PR again? It has received some changes after your last test. Thanks in advance.

avatar RickR2H
RickR2H - comment - 26 Apr 2022

@dgrammatiko Thanks for looking into this. Much appreciated!

I noticed that when I select the image via the select button I get: images/joomla_black.png#joomlaImage://local-images/joomla_black.png?width=225&height=50 But when I paste the URL like this: images/joomla_black.png I get the URL images/joomla_black.png#joomlaImage://local-images/joomla_black.png?width=225&height=225

Ik looks like when pasting the URL the exact image width and height are not respected and the image is default defined as squared.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.

avatar dgrammatiko
dgrammatiko - comment - 26 Apr 2022

Ik looks like when pasting the URL the exact image width and height are not respected and the image is default defined as squared

The wrong variable was passed fro the height, it should be ok after cf77958

avatar coolcat-creations
coolcat-creations - comment - 26 Apr 2022

Good catch! did not see this. I will test now as well ... waiting for the new prebuilt package :)

avatar RickR2H
RickR2H - comment - 26 Apr 2022

I have tested this item successfully on cf77958

Thanks @dgrammatiko


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.

avatar RickR2H RickR2H - test_item - 26 Apr 2022 - Tested successfully
avatar coolcat-creations
coolcat-creations - comment - 26 Apr 2022

I have tested this item successfully on cf77958

Thank you, tested successful as the given testing instructions.

The Preview seems not to work for svg tough but I think thats another issue


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.

avatar coolcat-creations coolcat-creations - test_item - 26 Apr 2022 - Tested successfully
avatar RickR2H RickR2H - change - 26 Apr 2022
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 26 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.

avatar roland-d roland-d - change - 26 Apr 2022
Labels Added: ?
avatar roland-d roland-d - change - 27 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-27 13:37:17
Closed_By roland-d
avatar roland-d roland-d - close - 27 Apr 2022
avatar roland-d roland-d - merge - 27 Apr 2022
avatar roland-d
roland-d - comment - 27 Apr 2022

Thanks everybody

Add a Comment

Login with GitHub to post a comment