User tests: Successful: Unsuccessful:
Pull Request for Issue # . Replaces #36945
images/sampledata/cassiopeia/not-valid.jpg
images/sampledata/cassiopeia/nasa1-400.jpg
#
parts!!!!)/images/sampledata/cassiopeia/nasa1-400.jpg
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
Category | JavaScript Repository NPM Change | ⇒ | JavaScript Repository NPM Change Layout |
did you read the description? Also what is the url you're entering?
I am testing on localhost with the patchtester
Yeah that won't work, try d/l the package at the end of this PR (GitHub)
Yes I read the description - maybe I misunderstood them or the issue is because i used patchtester. I will try with the prebuild package then. Thank you
@coolcat-creations should be fine now
I have tested this item
type (or copy paste) images/sampledata/cassiopeia/not-valid.jpg - done works (Validation message displayed)
type (or copy paste) images/sampledata/cassiopeia/nasa1-400.jpg - done works (#parts added)
type (or copy paste) /images/sampledata/cassiopeia/nasa1-400.jpg - done works (#parts added)
type (or copy paste) any valid external URL - done and works (image previewed, no # parts added as expected)
Thank you very much!!!
@coolcat-creations Could you test this PR again? It has received some changes after your last test. Thanks in advance.
@dgrammatiko Thanks for looking into this. Much appreciated!
I noticed that when I select the image via the select button I get: images/joomla_black.png#joomlaImage://local-images/joomla_black.png?width=225&height=50 But when I paste the URL like this: images/joomla_black.png I get the URL images/joomla_black.png#joomlaImage://local-images/joomla_black.png?width=225&height=225
Ik looks like when pasting the URL the exact image width and height are not respected and the image is default defined as squared.
Good catch! did not see this. I will test now as well ... waiting for the new prebuilt package :)
I have tested this item
Thanks @dgrammatiko
I have tested this item
Thank you, tested successful as the given testing instructions.
The Preview seems not to work for svg tough but I think thats another issue
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-27 13:37:17 |
Closed_By | ⇒ | roland-d |
Thanks everybody
@dgrammatiko I tested the patch and typing is possible but it does not update the preview after typing in / pasting the desired path