[#37636] - [4.2] Create the field in the base model when it doesn't exist
- Fixed in Code Base
- 25 Apr 2022
- Medium
- Build: 4.2-dev
- # 37636
- Diff
- Digital-Peak:j4/model/fields
User tests: Successful: Unsuccessful:
Summary of Changes
The database model has since #37095 a magic method to deliver the _dbo variable. This function needs to create the properties when they do not exist.
Testing Instructions
Edit a module in the back end.
Actual result BEFORE applying this Pull Request
The following error happens:
_Attempt to assign property "params" on null _
Expected result AFTER applying this Pull Request
Module form shows up.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Confirming that it fixes the broken pr
Wondring why the url contains an empty clientid
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636.
The pr #37095 is actually shipped with unit tests and the base model is tested with almost every system test we have. For sure there are always edge cases where something can break. In this case it broke because a model has an undeclared variable which is bad coding practice and will produce an error in PHP 9, when the RFC passes https://wiki.php.net/rfc/undefined_property_error_promotion.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37636.
| Labels |
Added:
?
?
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-25 17:40:40 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
Release Blocker
|
||
Thanks everybody
and that's why I said low level changes like #37095 should have better testing instructions and automated tests