Feeling Lucky
?
?
PR-4.4-dev
[#37635] - Get ordering from model in module controller
- Fixed in Code Base
- 4 Apr 2023
- Medium
- Build: 4.2-dev
- # 37635
- Diff
- Digital-Peak:j4/menus/ordering-model
User tests: Successful: Unsuccessful:
Summary of Changes
The module ordering controller task which is used in the ordering form field should use the model to fetch the modules for the same client and position.
Testing Instructions
Edit a module and click on the order form field.
Actual result BEFORE applying this Pull Request
The modules for the same client and position are listed.
Expected result AFTER applying this Pull Request
The modules for the same client and position are listed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
| Title |
|
||||||
| Labels |
Added:
?
|
||
laoneo
- comment
- 15 May 2022
Can you check if your branch is up to date with 4.2?
| Title |
|
||||||
joomla-bot
- comment
- 27 Jun 2022
A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#25
| Labels |
Added:
PR-4.3-dev
?
Removed: ? |
||
| Labels |
Removed:
?
|
||
| Title |
|
||||||
| Labels |
Added:
?
PR-4.4-dev
Removed: PR-4.3-dev |
||
richard67
- comment
- 4 Apr 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37635.
chmst
- comment
- 4 Apr 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37635.
| Status | Pending | ⇒ | Ready to Commit |
chmst
- comment
- 4 Apr 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37635.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-04 13:22:52 |
| Closed_By | ⇒ | MacJoom |
I have tested this item✅ successfully on 9d8af1d
Tested successfully in Joomla 4.2-alpha3-dev of 29 April in Wampserver 3.2.8 using PHP 8.0.15.
Had to change Error Reporting in Global Configuration from 'Maximum' to 'Simple' to get the Ordering info displayed, because of the PHP notice:
Notice: Only variable references should be returned by reference in C:\www\joomla42\libraries\src\MVC\Model\BaseDatabaseModel.php on line 418
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37635.