Feeling Lucky
?
Language Change
NPM Resource Changed
?
[#37574] - [4.2] Fix sampledata processed and message
- Fixed in Code Base
- 19 Jan 2023
- Medium
- Build: 4.1-dev
- # 37574
- Diff
- heelc29:issue-sampledata2
User tests: Successful: Unsuccessful:
Summary of Changes
Fix attribute for sample data set already processed
Possibility to translate the message which appears onError of ajax request
Testing Instructions
- Install a sample data set and press the same install button again (after successful execution) without reloading the page
- Enable lang debug and create an syntax error in
onAjaxSampledataApplyStep1function of the sample data plugin
Actual result BEFORE applying this Pull Request
Request to confirm start is displayed and js error
No possibility to translate the message if ajax-request fails
Expected result AFTER applying this Pull Request
Alert if sample data set is already installed and no js error
Possibility to translate the message if ajax-request fails
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules JavaScript Repository NPM Change |
| Labels |
Added:
Language Change
NPM Resource Changed
?
|
||
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Removed:
?
|
||
Quy
- comment
- 19 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37574.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 19 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37574.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-19 18:19:08 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
|
||
roland-d
- comment
- 19 Jan 2023
Thank you
I have tested this item✅ successfully on 635d5e3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37574.