[#37568] - Fix deprecation warning in com_tags
- Fixed in Code Base
- 3 Jun 2022
- Medium
- Build: 4.1-dev
- # 37568
- Diff
- chmst:tags-deprecatd-warning
User tests: Successful: Unsuccessful:
Pull Request for Issue #37567 .
Summary of Changes
The method getItem() returns an array but this is initialsed with "false".
Remark: It looks wrong that getItem() returns an array, but this is not in scope of this fix.
Testing Instructions
See #37567
Actual result BEFORE applying this Pull Request
Deprecation warning
Expected result AFTER applying this Pull Request
No deprecation warning
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
Not used to github on my IDE ;)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-16 11:00:58 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
PHP 8.x
|
||
If this is a better solution than my PR just close mine, no problem.
Sorry ;) By chance I ad exactly the same code open when your PR appeared. I think your solution is better. Both resolve the deprecated warning.
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-04-16 11:00:58 | ⇒ | |
| Closed_By | chmst | ⇒ |
| Status | New | ⇒ | Pending |
While this here is a correct fix, I'm wondering why it returns here
an array with only one element that is again an array of properties. Should it not return just the array with properties?
I mentioned already that this method looks strange. A method getItem() should return an Item, not an array and have one integer as argument, not an array. This fix resolves only the php 8.1 warning,
| Labels |
Added:
Maintainers Checked
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37568.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37568.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37568.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-03 08:41:05 |
| Closed_By | ⇒ | laoneo |
Thanks!
@chmst The issue which you have closed for this PR was not an issue but a PR, too. Maybe the issue tracker hasn’t shown that?