Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#37567] - [4.1] PHP 8.1 Deprecation warning TagModel

? ? PBF ? PHP 8.x Pending

User tests: Successful: Unsuccessful:

avatar frostmakk
frostmakk
16 Apr 2022

Testing Instructions

Install 4.1 with sample data.
Run on PHP 8.1 with maximum error reporting.
Go to front end and click on a tag.

Actual result BEFORE applying this Pull Request

PHP Deprecated: Automatic conversion of false to array is deprecated in ..\components\com_tags\src\Model\TagModel.php on line 318

Expected result AFTER applying this Pull Request

No deprecation warning from TagModel

Documentation Changes Required

avatar frostmakk frostmakk - open - 16 Apr 2022
avatar frostmakk frostmakk - change - 16 Apr 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2022
Category ⇒ com_tags Front End
avatar chmst chmst - change - 16 Apr 2022
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-04-16 10:45:55
Closed_By ⇒ chmst
Labels Added: ?
avatar chmst
chmst - comment - 16 Apr 2022

Closing. Please test #37568

avatar chmst chmst - close - 16 Apr 2022
avatar chmst chmst - change - 16 Apr 2022
Status Closed ⇒ New
Closed_Date 2022-04-16 10:45:55 ⇒
Closed_By chmst ⇒
avatar chmst chmst - change - 16 Apr 2022
Status New ⇒ Pending
avatar chmst chmst - reopen - 16 Apr 2022
avatar kiki-G
kiki-G - comment - 22 Apr 2022

I have tested this item ✅ successfully on 189d60f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567.

avatar kiki-G kiki-G - test_item - 22 Apr 2022 - Tested successfully
avatar kiki-G
kiki-G - comment - 22 Apr 2022

I have tested this item ✅ successfully on 189d60f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567.

avatar kiki-G kiki-G - test_item - 22 Apr 2022 - Tested successfully
avatar RickR2H
RickR2H - comment - 22 Apr 2022

I have tested this item ✅ successfully on 189d60f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567.

avatar RickR2H
RickR2H - comment - 22 Apr 2022

I have tested this item ✅ successfully on 189d60f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567.

avatar RickR2H RickR2H - test_item - 22 Apr 2022 - Tested successfully
avatar RickR2H RickR2H - change - 22 Apr 2022
The description was changed
Status Pending ⇒ Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 22 Apr 2022
avatar RickR2H
RickR2H - comment - 22 Apr 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567.

avatar kiki-G
kiki-G - comment - 22 Apr 2022

I have tested this item ✅ successfully on 189d60f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37567.

avatar kiki-G kiki-G - test_item - 22 Apr 2022 - Tested successfully
avatar laoneo laoneo - change - 23 Apr 2022
Labels Added: ? PBF PHP 8.x
avatar laoneo
laoneo - comment - 23 Apr 2022

The correct way is the fix from #37568 as the item needs to be an array as you can see here

joomla-cms/components/com_tags/src/Model/TagModel.php

Line 318 in 0e17958

$this->item[] = ArrayHelper::toObject($properties, CMSObject::class);
. So the item needs to be initialized as array. and returned as array.

avatar frostmakk
frostmakk - comment - 24 Apr 2022

@chmst
Closing in favor of #37568

avatar frostmakk frostmakk - change - 24 Apr 2022
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-04-24 14:13:08
Closed_By ⇒ frostmakk
Labels Added: ?
avatar frostmakk frostmakk - close - 24 Apr 2022

Add a Comment

Login with GitHub to post a comment