[#37517] - [4.2] Inject the cache controller factory
- Fixed in Code Base
- 12 Jun 2022
- Medium
- Build: 4.2-dev
- # 37517
- Diff
- Digital-Peak:j4/cache/inject
User tests: Successful: Unsuccessful:
Summary of Changes
Adds a new interface and trait to inject a CacheControllerFactoryInterface. Where possible this is used now in core.
Testing Instructions
Open the back end.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_postinstall Libraries |
| Labels |
Added:
?
|
||
the backend works after applying the patch?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517.
I have tested this item
if it's just opening the backend, it opened fine for me after applying patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517.
| Labels |
Added:
PBF
|
||
| Category | Administration com_postinstall Libraries | ⇒ | Administration com_postinstall Libraries Unit Tests |
| Labels |
Added:
?
|
||
I have tested this item
Apply patch, access to random pages from both frontend and backend, with both cache enabled/disabled, nothing is broken.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517.
@SumCompanyInc Could you please re-test this PR ? Thanks.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37517.
| Labels |
Added:
?
|
||
No need for a second test as I added only a unit test and made a function protected.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-12 07:27:18 |
| Closed_By | ⇒ | roland-d |
Thanks everybody
Impossible to test from the instructions provided