No Code Attached Yet
avatar brianteeman
brianteeman
8 Apr 2022

Steps to reproduce the issue

go to the extension installer.
inspect source and remove the class="hidden" from the div with id="loading"

Expected result

The joomla logo animated gif is displayed in the middle of the screen

Actual result

The gif is not displayed because of an error in the js which puts the loading div below the installer-install div instead of on top of it.

For the style top to be created this should be appended with + 'px'

loading.style.top = parseInt(installer.offsetTop - window.pageYOffset, 10);

But that offset makes no sense and as far as I can tell it should simply be top: 0

What is needed is an offsetleft which takes into account the width of the sidebar and then the loader will be displayed in the middle of the main div whether the sidebar is expanded or not.

Sadly my js knowledge is not good enough for that

avatar brianteeman brianteeman - open - 8 Apr 2022
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Apr 2022
avatar richard67 richard67 - change - 11 Apr 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-04-11 19:15:12
Closed_By richard67
avatar richard67 richard67 - close - 11 Apr 2022
avatar richard67
richard67 - comment - 11 Apr 2022

Closing as having a pull request. Please test #37538 . Thanks in advance.

Add a Comment

Login with GitHub to post a comment