? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Apr 2022

Pull Request for Issue #37487 .

Testing Instructions

on a joomla install using mysql pdo (eg in configuration.php it says public $dbtype = 'mysql'; not mysqli
open the template manager

Actual result BEFORE applying this Pull Request

the path is fubar

Expected result AFTER applying this Pull Request

the path is correct and no error messages when using the template manager

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar brianteeman brianteeman - open - 5 Apr 2022
avatar brianteeman brianteeman - change - 5 Apr 2022
Status New Pending
avatar brianteeman brianteeman - change - 5 Apr 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2022
Category Administration com_templates
avatar toivo
toivo - comment - 5 Apr 2022

I have tested this item successfully on 9d3eb69

Tested successfully in Joomla 4.1.3-dev in Wampserver 3.2.7 using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37489.

avatar toivo toivo - test_item - 5 Apr 2022 - Tested successfully
avatar Sandra97
Sandra97 - comment - 5 Apr 2022

I have tested this item successfully on 9d3eb69

It solves my issue.

Now the path is correct, and everything works fine, no more error messages and I can edit files.

Thanks a lot Brian.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37489.

avatar Sandra97 Sandra97 - test_item - 5 Apr 2022 - Tested successfully
avatar richard67 richard67 - change - 5 Apr 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 5 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37489.

avatar laoneo
laoneo - comment - 5 Apr 2022

Thanks for the pr, but would it not be easier to cast to int where the template is fetched form the database? Like that we fix it on the source of the issue and we do not have to patch it all over the core.

avatar bembelimen
bembelimen - comment - 6 Apr 2022

Thanks for the pr, but would it not be easier to cast to int where the template is fetched form the database? Like that we fix it on the source of the issue and we do not have to patch it all over the core.

Was wrking on the issue and had the same thought: #37497

avatar brianteeman brianteeman - change - 6 Apr 2022
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2022-04-06 16:33:15
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 6 Apr 2022
avatar toivo
toivo - comment - 21 Apr 2022

@Sandra97 please test #37497 which replaced this pull request #37489. The new #37987 should then be included in the next version of 4.1 and above.

Add a Comment

Login with GitHub to post a comment