? Composer Dependency Changed ? PHP 8.x Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
5 Apr 2022

Pull Request for Issue #37274.

Summary of Changes

Updates the PHP debugbar dependency to the commit with the latest PHP 8.1 fixes. It is basically the release 1.18.0 with the fixes.

Testing Instructions

  • Run Joomla on PHP 8.1
  • Enable debugging in the global Joomla configuration
  • Set error reporting to maximum in the global Joomla configuration
  • Make sure the debug plugin is enabled by default (is the case when doing a new installation)

Actual result BEFORE applying this Pull Request

The following error is shown:
Implicit conversion from float -INF to int loses precision in

Expected result AFTER applying this Pull Request

No error.

avatar laoneo laoneo - open - 5 Apr 2022
avatar laoneo laoneo - change - 5 Apr 2022
Status New Pending
avatar laoneo laoneo - edited - 5 Apr 2022
avatar laoneo laoneo - change - 5 Apr 2022
The description was changed
avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2022
Category External Library Composer Change
avatar laoneo laoneo - change - 5 Apr 2022
The description was changed
avatar laoneo laoneo - edited - 5 Apr 2022
avatar laoneo laoneo - change - 5 Apr 2022
Labels Added: Composer Dependency Changed ? PHP 8.x
avatar laoneo laoneo - change - 5 Apr 2022
Title
Use to PHP 8.1 fixes for debug bar dependency
[4.1] Use to PHP 8.1 fixes for debug bar dependency
avatar laoneo laoneo - edited - 5 Apr 2022
avatar exstreme
exstreme - comment - 7 Apr 2022

I have tested this item successfully on 1918150


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488.

avatar exstreme exstreme - test_item - 7 Apr 2022 - Tested successfully
avatar HLeithner
HLeithner - comment - 13 Apr 2022

Can you please pin the commit and not the branch. thx

avatar laoneo
laoneo - comment - 13 Apr 2022

I did that in my first commit 662e140 and then composer complained that that it is unsafe to do this and did abort on drone. The lock file is actually pointing to the commit, so we are covered to some degree.

avatar chmst
chmst - comment - 13 Apr 2022

I have tested this item successfully on ccae245

Tested on branch 4.1-dev,win11, xampp, php 8.1, debug mode "on" and error-reporting="maximum".

Before Patch: the application crashed with an eror 500, but not the message wich is mentioned in testing instructions.

After patch: application runs, no errors, no deprecated warnings.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488.

avatar chmst chmst - test_item - 13 Apr 2022 - Tested successfully
avatar laoneo laoneo - change - 13 Apr 2022
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 13 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37488.

avatar wilsonge wilsonge - change - 13 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-13 18:47:59
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 13 Apr 2022
avatar wilsonge wilsonge - merge - 13 Apr 2022
avatar wilsonge
wilsonge - comment - 13 Apr 2022

Thanks!

Add a Comment

Login with GitHub to post a comment