Feeling Lucky
?
[#37381] - [4.2] Add alias for old router class names in container
- Fixed in Code Base
- 27 Mar 2022
- Medium
- Build: 4.2-dev
- # 37381
- Diff
- Digital-Peak:j4/router/alias
User tests: Successful: Unsuccessful:
Summary of Changes
Adds an alias for the old router classes in container. Like that point the code $app::getRouter('Site'); to the same instance as Factory::getContainer()->get('SiteRouter');.
Testing Instructions
Add the following code to the file /plugins/system/schedulerunner/schedulerunner.php at line 110
$appRouter = $this->app::getRouter('Site');
$containerRouter = Factory::getContainer()->get('SiteRouter');
$appRouter->setVar('test', 'joomla');
echo $containerRouter->getVar('test');die;
Actual result BEFORE applying this Pull Request
Joomla is not printed.
Expected result AFTER applying this Pull Request
Joomla is printed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
joeforjoomla
- comment
- 26 Mar 2022
This PR is correct but it's the contrary:
Actual result BEFORE applying this Pull Request
Joomla is not printed
Expected result AFTER applying this Pull Request
Joomla is printed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37381.
laoneo
- comment
- 26 Mar 2022
Can you change it? Been away on phone only...
richard67
- comment
- 26 Mar 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37381.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 26 Mar 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37381.
| Labels |
Added:
?
|
||
laoneo
- comment
- 26 Mar 2022
Updated
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-27 07:54:41 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 27 Mar 2022
Thanks everybody
I have tested this item✅ successfully on 48262af
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37381.