I have tested this item ✅ successfully on 8331a2b

@Quy Have you tested by review?

I ask because it seems the multiselect feature seems to be broken in 4.2 (and maybe previous 4.x) compared to 3.

On J3 when I check one item's check box e.g. in the articles list and then check another one with pressed shift key, all items in the list between these 2 are selected, too. That's how I understand that it shall work according to the comment in file "build/media_source/system/js/multiselect.es6.js".

But on my 4.2 here this does not work, not without this PR and not with this PR.

By review this PR is ok to me, and it also does not change that broken behaviour.

See also #25500 .

@heelc29 How did you test yourself the "test multiselect" parts in your testing instructions? I'm asking because it seems that it doesn't work as it should in J4 (regardless of this PR here which is right).

On J3 I select an item in a list and then with pressed shift key I select another one more up or down in the list and not just the next or previous one, and then all items between the first and the 2nd selection get selected, too.

On J4 this seems not to work anymore.

So how did you test that? Did you just test that the "select all" check box still works?

Am only asking to understand that issue better. Nothing wrong with your PR here.

I have tested this item ✅ successfully on 8331a2b

Code review: The PR is right.

Real test: Multiselect seems to be broken in J4, see my previous comments. This PR doesn't change anything on that and so does not break anything further.

RTC

@heelc29 How did you test yourself the "test multiselect" parts in your testing instructions?

@richard67 I click somewhere in the row and check if the checkbox will go to checked.

On J3 I select an item in a list and then with pressed shift key I select another one more up or down in the list and not just the next or previous one, and then all items between the first and the 2nd selection get selected, too.

This feature I've not known until yet ;)

@richard67 multiselect has been broken since the beginning of j4 alpha. I opened an issue for it at the time. #25500

@richard67 multiselect has been broken since the beginning of j4 alpha. I opened an issue for it at the time. #25500

@brianteeman Yes, I have noticed that meanwhile.

Thank you :)