[#37366] - [6.0] Filter articles in admin module mod_latest by workflow stage
- Pending
- Medium
- Build: 4.1-dev
- # 37366
- Diff
- magnussinger:i36802
User tests: Successful: Unsuccessful:
Pull Request for Issue #36802
Summary of Changes
In the backends latest articles module, one can now filter by active stages from the workflows of the respective articles
Testing Instructions
Create multiple articles with different stages of workflows, then edit the module to filter certain stages
Actual result BEFORE applying this Pull Request
You were not able to filter by stages
Expected result AFTER applying this Pull Request
You are now able to filter by workflow stage
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
?
|
||
Hi @teekhandekar, you can always work on any issue if you want, and you don't need to ask for it. But in this case, I just had to merge the base branch into my branch, so it wasn't much to do.
@MagnusSinger can you rebase the pr to the 4.2-dev branch as it is a new feature?
Sure
| Labels |
Added:
?
Removed: ? |
||
Sorry but this is not correct.
- Instead of the sql field why not use the existing workflowstage field type. This has numerous advantages especially when there is more that one workflow on the site
- You are not checking to see if the site is using workflows before display the stage field
This pull requests has been automatically converted to the PSR-12 coding standard.
This pull request has been automatically rebased to 5.0-dev.
I have tested this item ✅ successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
I have tested this item ✅ successfully on b260e85
Tested on 5.0.0-beta1-dev PBF
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
With the patch applied I see a string key as may only choice: <option value="1">COM_WORKFLOW_BASIC_STAGE</option> in the Stage filter field.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
This pull request has been automatically rebased to 5.1-dev.
Tested the issue successfully ✅
I have tested this item ✅ successfully
Tested this on Joomla 5.1 alpha 4
There is no option to select no workflow. The first workflow stage in the list automatically selected.
There's a translation issue with com_workflow_basic_stage.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
I have tested this item ✅ successfully on b260e85
I have Tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
I have Tested this item successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
I have tested this item ✅ successfully on b260e85
Tested succesfully, works as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
Could not see any change in the Latest Article Module on 5.3.0-beta1 with the patch applied
Sorry, was not testing with the admin module. Now tested successfully!
I have tested this item ✅ successfully on b260e85
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
rdeutz
- | Title |
|
||||||
| Labels |
Added:
Feature
RTC
PBF
PR-6.0-dev
Removed: ? |
||
Not sure how anyone was able to test this successfully. There are several problems that I see when testing it
- The filter for workflow stage is displayed even when workflows is not enabled
- If you have multiple workflows then the selection list does not differentiate them
- The default Basic Workflow has only one stage but it is displayed as a language constant not a language value
I have tested this item 🔴 unsuccessfully on e2bdaf3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.
Looking back at all the previous comments I see that I am not the first to report the problems with this PR. It should never have been marked as RTC
QuyTon
- | Status | Ready to Commit | ⇒ | Pending |
@MagnusSinger hey! here it says that this branch is out-of-date with the base branch
so is the issue still open and if yes can I work on this ?