[#3736] - [#33833] Fix error message on "publish" exception in JcontrollerAdmin
- Closed
- 12 Jun 2014
- Medium
- Build: staging
- # 3736
- Diff
- izharaazmi:controlleradmin-publish
- Foreign ID 33833
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In case of ANY exception during "publish" the same error message was being displayed. The JLIB_DATABASE_ERROR_ANCESTOR_NODES_LOWER_STATE message is also irrelevant most of the times, like in non-nested tables.
Changed to show actual message string from the Exception object in catch argument.
To reproduce this error just do anything that will cause exception during publish of an item; then try to change publish state of that item.
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33833
Woops don't read the test instructions on JC. I will try it and report. Thanks @izharaazmi
Hi @zero-24, The straight-forward steps to force an exception is given at the JC Tracker. However there may be a real life exception as well.
Thanks @izharaazmi i can confirm your patch works good at my end 
@test, the patch shows the correct error message as thrown by the method handling the action.
Since you are removing the use of the string JLIB_DATABASE_ERROR_ANCESTOR_NODES_LOWER_STATE you will need to remove them from the language files as well.
administrator\language\en-GB\en-GB.com_categories.ini
administrator\language\en-GB\en-GB.com_menus.ini
administrator\language\en-GB\en-GB.com_tags.ini
administrator\language\en-GB\en-GB.lib_joomla.ini
language\en-GB\en-GB.lib_joomla.ini
Please update the language files as well.
| Title |
|
||||||
| Title |
|
||||||
Thanks @izharaazmi @roland-d moved the Tracker already to RTC
phproberto
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-06-12 23:59:49 |
Hi @izharaazmi is makes sense but i don't know how i can cause a exception during publish of an item.
Have you a simple example what we can do to trigger this exception?