[#3735] - [#33819] Fix for emailcloak plugin for cloaking email addresses with a plus chara...
- Closed
- 10 Jun 2014
- Medium
- Build: staging
- # 3735
- Diff
- Kubik-Rubik:email-cloaking-plus-char-fix
- Foreign ID 33819
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
...cter (+) properly
JoomlaCode entry: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33819&start=0
How to test:
Create article with following email addresses:
test@example.com
test+test@example.com
test+@example.com
+test@example.comLoad the article in the front end (of course the emailcloak plugin has to be activated). You will see that the addresses are not cloaked properly. If you deactivate JavaScript, then it is even clearer which parts are only considered by the plugin.
Add fix and reload the page. Each address will be cloaked completely and properly.
Further information: http://stackoverflow.com/questions/2049502/what-characters-are-allowed-in-email-address
| Title |
|
||||||
@zero-24 Yes, good idea. In fact, we just have to add the noscript tag to the replacement text. I will update the pull request with this option. Thanks!
Update:
The message is already displayed if JavaScript is deactivated, so we don't need the noscript tag here.
"This email address is being protected from spambots. You need JavaScript enabled to view it. "
thanks @Kubik-Rubik looks like that something is broken at my envoriment. So this is good to go 
Tested. Works fine!
phproberto
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-06-10 23:31:03 |
thanks @Kubik-Rubik
It works ok here. Now the mailto links correct. But IIRC if we disable JS (e.g. with NoScript) Joomla should replace the email with:
This email address is being protected from spambots. You need JavaScript enabled to view it.
But at my end it only remove the email.
Is the
element a possible chance?here:
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/html/email.php#L104
possible as a replacement of:
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/html/email.php#L95-103
As we cant use JS if JS is disabled ?!
Thanks.