[#37356] - [4.1] Align the inline help button to the rest of the btns
- Fixed in Code Base
- 3 Apr 2022
- Medium
- Build: 4.1-dev
- # 37356
- Diff
- dgrammatiko:4.1-dev-fix-btn-assets
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The static assets should only be added inside a layout. The inlinehelp toolbar button is adding the assets (a js file) inside the logic and this makes it impossible to override/remove the script in an easy fashion (eg by editing the relative layout). Also it's pretty obvious that this is wrong as it's the only button that doesn't adhere to the CMS' norm (add the assets only inside the layouts).
Testing Instructions
Apply the PR and check that the inlinehelp still works as before (check the global options)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No assets added in the logic
All the assets added in the layouts
Documentation Changes Required
No, but it would be good to pull a flag whenever a PR is adding static assets in places other than the layouts
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37356.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-03 11:03:12 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item✅ successfully on 50c0643
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37356.