PBF ? Pending

User tests: Successful: Unsuccessful:

avatar kitepascal
kitepascal
22 Mar 2022

Pull Request for Issue #37351 .

Summary of Changes

Testing Instructions

Save as Copy

Actual result BEFORE applying this Pull Request

Article is published.

Expected result AFTER applying this Pull Request

Article shoud be unpublished like in J3 before.

Documentation Changes Required

None.

Fixes #37351

avatar kitepascal kitepascal - open - 22 Mar 2022
avatar kitepascal kitepascal - change - 22 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2022
Category Administration com_content
avatar kitepascal kitepascal - change - 22 Mar 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-03-22 22:58:27
Closed_By kitepascal
Labels Added: ?
avatar kitepascal kitepascal - close - 22 Mar 2022
avatar kitepascal kitepascal - change - 22 Mar 2022
Status Closed New
Closed_Date 2022-03-22 22:58:27
Closed_By kitepascal
avatar kitepascal kitepascal - change - 22 Mar 2022
Status New Pending
avatar kitepascal kitepascal - reopen - 22 Mar 2022
avatar toivo
toivo - comment - 23 Mar 2022

I have tested this item successfully on b17c1c5

Tested successfully in 4.1.1-rc2-dev of 23 March using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37354.

avatar toivo toivo - test_item - 23 Mar 2022 - Tested successfully
avatar Shubhamverma2796
Shubhamverma2796 - comment - 23 Mar 2022

I have tested this item successfully on b17c1c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37354.

avatar Shubhamverma2796 Shubhamverma2796 - test_item - 23 Mar 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 Mar 2022

I am a little unsure that this is the correct fix. It would be useful to find out when/where the j3 behaviour was changed. Was there a reason for it, was anything else changed at the same time. There may be more needed than just this one line.

avatar richard67
richard67 - comment - 23 Mar 2022

I am a little unsure that this is the correct fix. It would be useful to find out when/where the j3 behaviour was changed. Was there a reason for it, was anything else changed at the same time. There may be more needed than just this one line.

Yes, I have the same feeling, but I'm at work so can't investigate. I hope someone else can step in if necessary.

avatar brianteeman
brianteeman - comment - 23 Mar 2022

Well there is no rush to merge it ;)

Thinking aloud but it might be something to do with the creation of multilingual associated articles

avatar kitepascal
kitepascal - comment - 23 Mar 2022

it might be something to do with the creation of multilingual associated articles

Created multilingual associated articles are still published initially, just tested that.
Also if you create an associated translation of an unpublished article.

avatar laoneo
laoneo - comment - 23 Mar 2022

Perhaps @bembelimen can shed some light in here as it can relate to the workflow changes.

avatar kitepascal kitepascal - change - 23 Mar 2022
Labels Added: ?
avatar richard67
richard67 - comment - 23 Mar 2022

Perhaps @bembelimen can shed some light in here as it can relate to the workflow changes.

I think that could be the point. When workflow is enabled, it should use the default stage, which might be different. Maybe we should look up in the code how it's done for batch copying?

avatar bembelimen
bembelimen - comment - 23 Mar 2022

Workflow didn't change the behaviour... I wanted to do so, but there was too much restistant and for me it was not worth the time to fight for it...so I think copy should always save unpublished, but that is just my opinion.

avatar brianteeman
brianteeman - comment - 23 Mar 2022

Well something changed it - weird

avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar Quy
Quy - comment - 4 Feb 2023

Closing in favor of #38810 as it has more in-depth discussion. Thank you for your contribution.

avatar Quy Quy - close - 4 Feb 2023
avatar Quy Quy - change - 4 Feb 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-02-04 18:13:58
Closed_By Quy
Labels Added: PBF ?
Removed: ? ?

Add a Comment

Login with GitHub to post a comment