No Code Attached Yet bug
avatar Stuartemk
Stuartemk
22 Mar 2022

What needs to be fixed

Just download and install the zip
Copy the template compare database and both contain Brand "1"

Change the name of the copied template and compare the databases and in the *_template_styles table there was a change in the Brand record. It went from "1" to true.

In the first step when making the copy of the original template it was kept as "1", the difference was caused by changing the name of the copied template, it was at that moment that it changed from "1" to true.

Original
{"brand":"1","logoFile":"","siteTitle":"","siteDescription":"","useFontScheme":"0","colorName":"colors_standard","fluidContainer":"0","stickyHeader":0,"backTop":0}

Copied
{"brand":"1","logoFile":"","siteTitle":"","siteDescription":"","useFontScheme":"0","colorName":"colors_standard","fluidContainer":"0","stickyHeader":0,"backTop":0}

Change Name
{"brand":true,"logoFile":"","siteTitle":"","siteDescription":"","useFontScheme":"0","colorName":"colors_standard","fluidContainer":"0","stickyHeader":0,"backTop":0}

Why this should be fixed

How would you fix it

Side Effects expected

avatar Stuartemk Stuartemk - open - 22 Mar 2022
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Mar 2022
avatar Stuartemk Stuartemk - change - 22 Mar 2022
The description was changed
avatar Stuartemk Stuartemk - edited - 22 Mar 2022
avatar Stuartemk Stuartemk - change - 22 Mar 2022
The description was changed
avatar Stuartemk Stuartemk - edited - 22 Mar 2022
avatar richard67 richard67 - change - 23 Mar 2022
Title
Joomla_4.1.1-rc2-dev-Development-Full_Package Brand change "1" to true
[4.1] Brand change "1" to true
avatar richard67 richard67 - edited - 23 Mar 2022
avatar ReLater
ReLater - comment - 24 Mar 2022

In my case it's sufficient to open & save the template style "Cassiopeia - Default" to have in params field of db table template_styles a "brand":true or false. After Joomla installation it was "brand":1.

It's not really an issue (but inconsistency) because cassiopeia code doesn't use "type-casted" checks for this setting (but integer for default value 1). Example:

<?php if ($this->params->get('brand', 1)) : ?>

Addition: The relevant field is a radio field with switcher layout.

avatar Hackwar Hackwar - change - 17 Feb 2023
Labels Added: bug
avatar Hackwar Hackwar - labeled - 17 Feb 2023
avatar chmst chmst - close - 26 Aug 2023
avatar chmst
chmst - comment - 26 Aug 2023

Please test #4148

avatar chmst chmst - change - 26 Aug 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-08-26 09:53:11
Closed_By chmst
avatar richard67
richard67 - comment - 26 Aug 2023

Please test #4148

#41458 !

Add a Comment

Login with GitHub to post a comment