No Code Attached Yet bug
avatar coolcat-creations
coolcat-creations
22 Mar 2022

Steps to reproduce the issue

In the previous Joomla version Save as Copy task saved the article as copy but unpublished
Now the Save as Copy task automatically publishes the article

Expected result

When do you want to save something as a copy? Probably when you want to take the existing one as a draft for the next one. In this case you would not want to have it published until you are finished with your editing. In Joomla 4 somehow this changed.

Actual result

When you open an article and click on the Save as Copy Button, the copy is created and published.

System information (as much as possible)

Joomla 4.1.0

Additional comments

Reported by Dominik on Facebook, I agree that this is not user friendly

avatar coolcat-creations coolcat-creations - open - 22 Mar 2022
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Mar 2022
avatar coolcat-creations coolcat-creations - change - 22 Mar 2022
Title
[J 4.1.x] Save as copy saves article publised
[J 4.1.x] Save as copy saves article published
avatar coolcat-creations coolcat-creations - edited - 22 Mar 2022
avatar richard67
richard67 - comment - 22 Mar 2022

From steps to reproduce the issue:

Not the Save as Copy task automatically publishes the article

@coolcat-creations I think you meant „Now“ and not „Not“. Am I right?

avatar coolcat-creations coolcat-creations - change - 22 Mar 2022
The description was changed
avatar coolcat-creations coolcat-creations - edited - 22 Mar 2022
avatar coolcat-creations
coolcat-creations - comment - 22 Mar 2022

Thank you @richard67 - updated!

avatar chmst
chmst - comment - 22 Mar 2022

@coolcat-creations thanks for reporting. that's surely not intended, as in modules the copy also is unpublished.

avatar brianteeman
brianteeman - comment - 22 Mar 2022

.. and batch actions copy is also unpublished

avatar kitepascal
kitepascal - comment - 22 Mar 2022

.. and batch actions copy is also unpublished

For batch actions that's reasonable.
The batch copies are intended to be edited before publishing.

In edit view, from the logical side, a copy is a copy with copied parameters, 1:1, form saved like selected (can be changed before hitting the button).
First thing I did in J3 was to publish the "Save as Copy" but unpublished copy or menu item.

Out of habit, the old behaviour is also fine. It should be consistent between articles and modules.

avatar chmst
chmst - comment - 22 Mar 2022

You cannot make everyone happy. I think whatever is done here will be returned in a following PR.

avatar kitepascal
kitepascal - comment - 22 Mar 2022

I'm very unhappy about still not being able to do a single line PR without issues.
I did not get it to detach the former commits through browser. Sorry for that! ??‍♂️

avatar richard67
richard67 - comment - 23 Mar 2022

I'm very unhappy about still not being able to do a single line PR without issues.
I did not get it to detach the former commits through browser. Sorry for that! ??‍♂️

@kitepascal You are talking about #37354 ? It looks ok.

avatar richard67 richard67 - close - 23 Mar 2022
avatar richard67
richard67 - comment - 23 Mar 2022

Closing as having a pull request.

avatar richard67 richard67 - change - 23 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-23 06:55:21
Closed_By richard67
avatar richard67
richard67 - comment - 23 Mar 2022

@kitepascal I think your problem was that you have used your 4.1-dev branch for the PR, and that branch had other changes before. It is better to create a new, dedicated branch based on the 4.1-dev branch of the upstream repository (= this one here from the point of view of your fork) for each PR.

avatar Quy Quy - change - 12 Oct 2023
Status Closed New
Closed_Date 2022-03-23 06:55:21
Closed_By richard67
avatar Quy Quy - reopen - 12 Oct 2023
avatar AndySDH
AndySDH - comment - 18 Oct 2023

+1 to this, this should be addressed.

It was fixed in #38810, but it was reverted in #41790

avatar C00kiekiller
C00kiekiller - comment - 25 Mar 2024

+1 to this, this should be addressed.

avatar Hackwar Hackwar - change - 26 Mar 2024
Labels Added: bug
avatar Hackwar Hackwar - labeled - 26 Mar 2024

Add a Comment

Login with GitHub to post a comment