[#37330] - [4.2] (re) Introduce a body end renderer
- Closed
- 24 Mar 2022
- Medium
- Build: 4.2-dev
- # 37330
- Diff
- dgrammatiko:4.2-dev-body-end-renderer
User tests: Successful: Unsuccessful:
Pull Request is the base for many Issues associated with modals. Fixes #37297
Summary of Changes
- Introduces another renderer
- Adds setter/getter for the enqueued html fragments
Testing Instructions
Backend Toolbars
Try to edit an article and check the source of the document (scroll to the end) [preferably with debug disabled]
Apply the PR
Check again the source, the last entries before < /body > should be some modals
Check that the toolbar buttons versions, preview and a11y checks are all functionals
Backend Multiple editors in different tabs #37297
Ensure the global editor is set to 'None'
Edit administrator/components/com_content/forms/article.xml and add
<field name="xoxo" type="editor" editor="none" buttons="true" />After line 264. Try to check if both editors have functional buttons
Apply the PR and repeat the test
Repeat the test for code mirror
Actual result BEFORE applying this Pull Request
Chunks of HTML can only be echoed sequentially, eg the toolbar modals are echoed immediately after the button
Expected result AFTER applying this Pull Request
Chunks of HTML can be enqueued to be echoed at the end of the document
Documentation Changes Required
@laoneo this is needed if you want to see any improvement on the modals
@roland-d in order to solve #37297 and a few more modal related issues this (or something similar) is required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change JavaScript Layout Libraries |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Repository NPM Change JavaScript Layout Libraries | ⇒ | Administration com_content Repository NPM Change JavaScript Layout Libraries |
| Category | Repository NPM Change JavaScript Layout Libraries Administration com_content | ⇒ | Administration com_content Repository NPM Change JavaScript Layout Libraries Front End Plugins |
@brianteeman @alikon that article is talking about implementing an own serialised/unserializer and that for 8.1 it needs both the old and the new functions. But I'm not using implements here. So is this an issue here?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-24 18:29:27 |
| Closed_By | ⇒ | dgrammatiko |
Why did you close?
There's nothing in their docs: https://www.php.net/manual/en/function.serialize.php
But probably I could do this in another way