? ? PHP 8.x Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
20 Mar 2022

Summary of Changes

Ads some checks in menu items if the links are not null. These checks are needed on PHP 8.1 as it will throw a deprecated message.

Testing Instructions

Open the new menu item form.

Actual result BEFORE applying this Pull Request

Following error is thrown:
Deprecated: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in /administrator/components/com_menus/src/Model/ItemModel.php on line 1150

Expected result AFTER applying this Pull Request

No error.

avatar laoneo laoneo - open - 20 Mar 2022
avatar laoneo laoneo - change - 20 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2022
Category Administration com_menus
avatar tecpromotion
tecpromotion - comment - 20 Mar 2022

I have tested this item successfully on 01c4a7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37325.

avatar tecpromotion tecpromotion - test_item - 20 Mar 2022 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 20 Mar 2022

I have tested this item successfully on 01c4a7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37325.

avatar dgrammatiko dgrammatiko - test_item - 20 Mar 2022 - Tested successfully
avatar alikon alikon - change - 21 Mar 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37325.

avatar bembelimen bembelimen - close - 24 Mar 2022
avatar bembelimen bembelimen - merge - 24 Mar 2022
avatar bembelimen bembelimen - change - 24 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-24 21:44:23
Closed_By bembelimen
Labels Added: ? ? PHP 8.x
avatar bembelimen
bembelimen - comment - 24 Mar 2022

Thx

Add a Comment

Login with GitHub to post a comment