Feeling Lucky
?
?
PHP 8.x
[#37325] - [4.1] Check if links are not null in menu item
- Fixed in Code Base
- 24 Mar 2022
- Medium
- Build: 4.1-dev
- # 37325
- Diff
- Digital-Peak:j4/menu/item-81
User tests: Successful: Unsuccessful:
Summary of Changes
Ads some checks in menu items if the links are not null. These checks are needed on PHP 8.1 as it will throw a deprecated message.
Testing Instructions
Open the new menu item form.
Actual result BEFORE applying this Pull Request
Following error is thrown:
Deprecated: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in /administrator/components/com_menus/src/Model/ItemModel.php on line 1150
Expected result AFTER applying this Pull Request
No error.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
dgrammatiko
- comment
- 20 Mar 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37325.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 21 Mar 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37325.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-24 21:44:23 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
PHP 8.x
|
||
bembelimen
- comment
- 24 Mar 2022
Thx
I have tested this item✅ successfully on 01c4a7b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37325.