[#37324] - [4.1] Check if string is null in hasKey function
- Fixed in Code Base
- 24 Mar 2022
- Medium
- Build: 4.1-dev
- # 37324
- Diff
- Digital-Peak:j4/plugins/form-81
User tests: Successful: Unsuccessful:
Summary of Changes
When editing a plugin a deprecated warning is displayed on PHP 8.1.
Testing Instructions
In the back end open a plugin form.
Actual result BEFORE applying this Pull Request
The following deprecated message is shown:
Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in /libraries/src/Language/Language.php on line 1181
Expected result AFTER applying this Pull Request
No warning.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PHP 8.x
|
||
It is again something which is supported since a long time, so it should not throw a deprecate message on PHP 8.1. It appears on menu items, modules and probably also other places in core. Why not fixing the source instead of telling every extension dev to check if there is null passed?
I have tested this item
I have successfully tested the PR independently of the discussion.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37324.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37324.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37324.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-24 20:25:57 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
|
||
Thx
how is the stack trace? null is never an valid language string right and should be fixed at the source.