Feeling Lucky
?
NPM Resource Changed
?
[#37276] - # Fix maximum media modal width
- Fixed in Code Base
- 17 Mar 2022
- Medium
- Build: 4.1-dev
- # 37276
- Diff
- toroworx:fix/mediapreviewsize
User tests: Successful: Unsuccessful:
Pull Request for Issue #
#37277
Summary of Changes
When using the modal preview for images with large images, images gets cut off.
Testing Instructions
- Upload a width-wise large image to your Joomla images folder.
- Go to Joomla media manager and select said image.
- Preview the image; it's cut off.
Actual result BEFORE applying this Pull Request
Images only partly visible.
Expected result AFTER applying this Pull Request
Images fully visible, because of proper width.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
richard67
- comment
- 15 Mar 2022
@richard67 do you haven an idea why the build is failing?
Because it can?
chmst
- comment
- 16 Mar 2022
The change was made here #34634.
@dgrammatiko could you have a look?
dgrammatiko
- comment
- 16 Mar 2022
It's fine, I have no clue why it was changed to 200%
Quy
- comment
- 16 Mar 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37276.
chmst
- comment
- 16 Mar 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37276.
| Status | Pending | ⇒ | Ready to Commit |
chmst
- comment
- 16 Mar 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37276.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-17 20:05:21 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
bembelimen
- comment
- 17 Mar 2022
Thx
@richard67 do you haven an idea why the build is failing?