Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#37275] - Fix advanced search mod_finder in header

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
14 Mar 2022

This is a proposal Pull Request for Issue #37263

Summary of Changes

The styling of the advanced search is broken when used in the header. This PR adds the same styling als used in the left and right position. @brianteeman please review and comment.

Testing Instructions

Add PR and build the CSS. For testing see issue mentioned above.

Actual result BEFORE applying this Pull Request

Search button is stretchend and colors are wrong.

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar RickR2H RickR2H - open - 14 Mar 2022
avatar RickR2H RickR2H - change - 14 Mar 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2022
Category ⇒ Repository NPM Change
avatar richard67
richard67 - comment - 14 Mar 2022

@RickR2H Code style errors see here: https://ci.joomla.org/joomla/joomla-cms/52396/1/24

avatar brianteeman
brianteeman - comment - 14 Mar 2022

I have tested this item ✅ successfully on e073c7a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37275.

avatar brianteeman brianteeman - test_item - 14 Mar 2022 - Tested successfully
avatar RickR2H RickR2H - change - 14 Mar 2022
Labels Added: NPM Resource Changed ?
avatar RickR2H
RickR2H - comment - 14 Mar 2022

@RickR2H Code style errors see here: https://ci.joomla.org/joomla/joomla-cms/52396/1/24

I was on it ;) Man you are quick!

avatar brianteeman
brianteeman - comment - 14 Mar 2022

I have tested this item ✅ successfully on 695f62b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37275.

avatar brianteeman brianteeman - test_item - 14 Mar 2022 - Tested successfully
avatar richard67
richard67 - comment - 14 Mar 2022

Testing Instructions

Add PR and build the CSS. For testing see PR mentioned above.

@RickR2H I assume you mean "issue" and not "PR".

avatar RickR2H RickR2H - change - 14 Mar 2022
The description was changed
avatar RickR2H RickR2H - edited - 14 Mar 2022
avatar richard67
richard67 - comment - 14 Mar 2022

I have tested this item ? unsuccessfully on 695f62b

Menu items in pull down submenus now have white text on white background.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37275.

avatar richard67 richard67 - test_item - 14 Mar 2022 - Tested unsuccessfully
avatar richard67
richard67 - comment - 14 Mar 2022

j4 1-test-pr-37275-failed

avatar RickR2H
RickR2H - comment - 14 Mar 2022

@richard67 should be fixed now...

avatar richard67
richard67 - comment - 14 Mar 2022

Will test tomorrow.

avatar brianteeman
brianteeman - comment - 15 Mar 2022

I have tested this item ✅ successfully on d58636f

menu items ok now

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37275.

avatar brianteeman brianteeman - test_item - 15 Mar 2022 - Tested successfully
avatar richard67 richard67 - alter_testresult - 15 Mar 2022 - brianteeman: Tested successfully
avatar richard67
richard67 - comment - 15 Mar 2022

I've restored the previous test result in the issue tracker since the commit which invalidated the test counter was just a clean branch update.

avatar RickR2H
RickR2H - comment - 15 Mar 2022

Thanks @richard67

avatar richard67
richard67 - comment - 15 Mar 2022

I have tested this item ✅ successfully on d3e5314

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37275.

avatar richard67 richard67 - test_item - 15 Mar 2022 - Tested successfully
avatar richard67 richard67 - change - 15 Mar 2022
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 15 Mar 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37275.

avatar bembelimen bembelimen - change - 18 Mar 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-03-18 13:41:34
Closed_By ⇒ bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 18 Mar 2022
avatar bembelimen bembelimen - merge - 18 Mar 2022
avatar bembelimen
bembelimen - comment - 18 Mar 2022

Thx

Add a Comment

Login with GitHub to post a comment