? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Mar 2022

Summary of Changes

Give the filter buttons some love

Testing Instructions

Edit an article on the front end and use any of the xtd-editor plugins eg Insert article
and
Test the versions button at the bottom

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

there is no change with the versions popup as the css was not used there

avatar brianteeman brianteeman - open - 13 Mar 2022
avatar brianteeman brianteeman - change - 13 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2022
Category Repository NPM Change
avatar richard67
richard67 - comment - 13 Mar 2022

@brianteeman Have you checked also with RTL?

avatar richard67
richard67 - comment - 13 Mar 2022

I have tested this item successfully on cb2d7a6

Filter buttons have equal distance now. Content history modal not changes. RTL also fine regarding these changes (other RTL glitches are unrelated).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37260.

avatar richard67 richard67 - test_item - 13 Mar 2022 - Tested successfully
avatar Quy
Quy - comment - 13 Mar 2022

37260-menu

avatar brianteeman brianteeman - change - 13 Mar 2022
Labels Added: NPM Resource Changed ?
cbe8984 13 Mar 2022 avatar brianteeman cs
avatar richard67
richard67 - comment - 14 Mar 2022

I have tested this item successfully on cbe8984


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37260.

avatar richard67 richard67 - test_item - 14 Mar 2022 - Tested successfully
avatar khu5h1
khu5h1 - comment - 14 Mar 2022

I have tested this item successfully on cbe8984


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37260.

avatar khu5h1 khu5h1 - test_item - 14 Mar 2022 - Tested successfully
avatar richard67 richard67 - change - 14 Mar 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 14 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37260.

avatar laoneo laoneo - change - 18 Mar 2022
Labels Added: ?
avatar laoneo laoneo - change - 18 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-18 11:38:11
Closed_By laoneo
avatar laoneo laoneo - close - 18 Mar 2022
avatar laoneo laoneo - merge - 18 Mar 2022
avatar laoneo
laoneo - comment - 18 Mar 2022

Thanks!

avatar brianteeman
brianteeman - comment - 18 Mar 2022

thanks

Add a Comment

Login with GitHub to post a comment