? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Mar 2022

Pull Request for Issue # .

Summary of Changes

Remove incorrect margin bottom

Testing Instructions

Add this markup into an article - taken directly from bootstrap docs

<div class="btn-group" role="group" aria-label="Button group with nested dropdown">
  <button type="button" class="btn btn-primary">1</button>
  <button type="button" class="btn btn-primary">2</button>

  <div class="btn-group" role="group">
    <button id="btnGroupDrop1" type="button" class="btn btn-primary dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false">
      Dropdown
    </button>
    <ul class="dropdown-menu" aria-labelledby="btnGroupDrop1">
      <li><a class="dropdown-item" href="#">Dropdown link</a></li>
      <li><a class="dropdown-item" href="#">Dropdown link</a></li>
    </ul>
  </div>
</div>

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

none

NOTE

dont worry that the dropdown doesnt work. its unrelated and because the relevant js is not loaded in an article

avatar brianteeman brianteeman - open - 13 Mar 2022
avatar brianteeman brianteeman - change - 13 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2022
Category Repository NPM Change
avatar richard67
richard67 - comment - 13 Mar 2022

@brianteeman As far as I've seen, the code which is removed by your PR has been added with this PR in the Cassiopeia repo due to this issue in the same repo. So I have checked if your PR reverts that fix, and it seems it does.

Without this PR here:
j4 1-test-pr-37259_filter-fields-before

With your PR:
j4 1-test-pr-37259_filter-fields-after

Is this intended?

avatar brianteeman
brianteeman - comment - 13 Mar 2022

no. that explains why the margin was present but in the wrong place. Updating ...

avatar brianteeman brianteeman - change - 13 Mar 2022
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 13 Mar 2022

@richard67 took a different approach should be correct in both places now

avatar richard67
richard67 - comment - 13 Mar 2022

I have tested this item successfully on 8c3e5cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37259.

avatar richard67 richard67 - test_item - 13 Mar 2022 - Tested successfully
avatar Quy
Quy - comment - 14 Mar 2022

I have tested this item successfully on 8c3e5cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37259.

avatar Quy Quy - test_item - 14 Mar 2022 - Tested successfully
avatar Quy Quy - change - 14 Mar 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 14 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37259.

avatar laoneo laoneo - change - 18 Mar 2022
Labels Added: ?
avatar laoneo
laoneo - comment - 18 Mar 2022

Thanks!

avatar laoneo laoneo - close - 18 Mar 2022
avatar laoneo laoneo - merge - 18 Mar 2022
avatar laoneo laoneo - change - 18 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-18 13:23:15
Closed_By laoneo
avatar brianteeman
brianteeman - comment - 18 Mar 2022

thanks

Add a Comment

Login with GitHub to post a comment