[#37204] - [4.1]Saving update key into extra_query in #__update_sites leaves update site checked out
- Closed
- 5 Mar 2022
- Medium
- Build: 4.1.1-dev
- # 37204
Steps to reproduce the issue
Install a third party extension that requires a download key like Akeeba Backup Pro
Go to System - Update - Update Sites.
The installed third party extension displays the text 'The Download Key key missing' in red background.
Select the update site.
Enter the required value into the field Download Key.
Save and Close.
The extension shows the text Download Key in blue background and the value of the download key.
Go to System - Maintenance.
Expected result
Global Check-in shows no items to be checked in.
Actual result
Global Check-in shows that an item needs to be checked in.
System information (as much as possible)
Joomla 4.1.1-dev of 5 March 2022, Wampserver 3.2.7 with PHP 8.0.15
Additional comments
In each case the row in #__update_sites has the following values:
- checked_out 0
- checked_out_time 0000-00-00 00:00:00
The issue was reproduced in 4.1.0 and 4.1.1-dev with the latest versions of Akeeba Backup Pro, Akeeba Admin Tools Pro and JCE Pro.
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
Hmm I think it is related because I remember now that the zerodate value for the checked_out_time caused an extension to be shown as checked out. Not sure yet where to fix it.
Will investigate later … I think I have an idea where to start.
It is MySQL 8.0.27. The Extensions view does not show any extensions as checked out and I checked the extensions table, too. Only the Global Checkin shows the checked out update sites. Will update once I find the MySQL logs.
Ok, thank you @richard67
I can easily install either 4.1 or 4.1.1-dev and I am available for testing after about 1.5 hours
I think I will need more than 1.5 hours because will soon be busy with other stuff.
Ok, no problems.
It can be reproduced with this fake "paid download" extension Null file which was used for testing several PRs in past, e.g. #34419 or #34386 . Thanks @nikosdion for the file.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-05 17:57:04 |
| Closed_By | ⇒ | richard67 |
Which kind of database server (MySQL or MariaDB) and which version did you use? Do you have any SQL failures in the database server‘s log file? I ask because it seems that the extension still uses the old zerodates which are deprecated in MySQL 8 and not real null values.
Not sure if it’s related, just asking.