? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar kitepascal
kitepascal
5 Mar 2022

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar kitepascal kitepascal - open - 5 Mar 2022
avatar kitepascal kitepascal - change - 5 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2022
Category Administration Language & Strings
avatar kitepascal
kitepascal - comment - 5 Mar 2022

Lets wait for @nikosdion s PR and some more tests.

Joomlas language override fields convert < br > to < br /> on save/reload, so I accepted that.

Should we also link @ceford s detail-documentation directly from PLG_SYSTEM_WEBAUTHN_FIELD_DESC ?

avatar brianteeman
brianteeman - comment - 5 Mar 2022

Joomlas language override fields convert < br > to < br /> on save/reload, so I accepted that.

That's a bug which hopefully will get fixed. Please make the requested chanage

avatar kitepascal kitepascal - change - 5 Mar 2022
Labels Added: Language Change ?
avatar tecpromotion
tecpromotion - comment - 5 Mar 2022

There are unnecessary spaces before and after br. Please delete.

Furthermore, I see no need for the last sentence and the link here.

avatar kitepascal
kitepascal - comment - 5 Mar 2022

I got used to add EOL spaces for anti-glued sentences if somehow line breaks get lost (or just take copy/paste w/o line breaks).

Unlikely here, so I will remove them (cannot hurt anyway).

For the "read more" link, last sentence - I think it is good and very, very useful to have them in scope, like "read more" in frontend. Its just following the intro/short form.

The top right help button is not really in scope and that last sentence with link does not hurt anything/anybody - rather the opposite.
The translations (+ possibly link(s)) and also the help button contents have to be updated anyway, if core Strings get improved for usability.

Maybe theres another 3rd party opinion on that - updated PR will follow.

avatar kitepascal
kitepascal - comment - 6 Mar 2022

Thx @tecpromotion - to change only the one string makes sense to save the translators crowd from unnecessary work (y)

avatar tecpromotion
tecpromotion - comment - 6 Mar 2022

I have tested this item successfully on a4a2140


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37203.

avatar tecpromotion tecpromotion - test_item - 6 Mar 2022 - Tested successfully
avatar RickR2H
RickR2H - comment - 6 Mar 2022

I have tested this item successfully on a4a2140


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37203.

avatar RickR2H RickR2H - test_item - 6 Mar 2022 - Tested successfully
avatar RickR2H RickR2H - change - 6 Mar 2022
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 6 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37203.

avatar bembelimen bembelimen - change - 7 Mar 2022
Title
WebAuthn hints
[4.1] WebAuthn hints
avatar bembelimen bembelimen - edited - 7 Mar 2022
avatar bembelimen bembelimen - close - 12 Mar 2022
avatar bembelimen bembelimen - merge - 12 Mar 2022
avatar bembelimen bembelimen - change - 12 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-12 10:38:33
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 12 Mar 2022

Thx

Add a Comment

Login with GitHub to post a comment