? ? Pending

User tests: Successful: Unsuccessful:

avatar Shubhamverma2796
Shubhamverma2796
2 Mar 2022

Pull Request for Issue #37109.

Summary of Changes

Added a quick log-out button.

Testing Instructions

Try to log out using the quick log out button outside the dropdown.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

see #37109

Documentation Changes Required

avatar Shubhamverma2796 Shubhamverma2796 - open - 2 Mar 2022
avatar Shubhamverma2796 Shubhamverma2796 - change - 2 Mar 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2022
Category Modules Administration
avatar Shubhamverma2796 Shubhamverma2796 - change - 2 Mar 2022
Title
Issue 37109
Added a quick log-out button
avatar Shubhamverma2796 Shubhamverma2796 - edited - 2 Mar 2022
avatar richard67
richard67 - comment - 3 Mar 2022

Shouldn't the logout then be removed from the dropdown because the entry there is redundant when this new button is implemented?

avatar Shubhamverma2796 Shubhamverma2796 - change - 4 Mar 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 4 Mar 2022

I have tested this item 🔴 unsuccessfully on 65cc20b

Always test your changes before asking others to do so


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37183.

avatar brianteeman brianteeman - test_item - 4 Mar 2022 - Tested unsuccessfully
avatar Shubhamverma2796
Shubhamverma2796 - comment - 4 Mar 2022

Shouldn't the logout then be removed from the dropdown because the entry there is redundant when this new button is implemented?

I've removed the log out from the drop down.

avatar brianteeman
brianteeman - comment - 4 Mar 2022

Try to use your code and you will see

avatar ChristineWk
ChristineWk - comment - 4 Mar 2022

I have tested this item successfully on d40bf36

@chmst could you check A11Y please. Thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37183.

avatar ChristineWk ChristineWk - test_item - 4 Mar 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 4 Mar 2022

@ChristineWk There are quite a few changes that need to be made

avatar ChristineWk
ChristineWk - comment - 4 Mar 2022

@brianteeman
Ah. Didn't see the changes after d40bf36. But now under github (not on issue view). Will revert test result.

avatar ChristineWk
ChristineWk - comment - 4 Mar 2022

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37183.

avatar ChristineWk ChristineWk - test_item - 4 Mar 2022 - Not tested
avatar Shubhamverma2796
Shubhamverma2796 - comment - 4 Mar 2022

@ChristineWk can you please test it again. Thanks.

avatar chmst
chmst - comment - 4 Mar 2022

@Shubhamverma2796

  1. The comment of @simbus82 about the icon also is valid. #37109 (comment) A user does not switch power on off, but he signs out. So the icon-exit would be fine for me, at least for users with ltr languages. Could you use icon-exit?
    @brianteeman are we using a power-on-off icon due to rtl and ltr language, als exit has an arrow-right?

  2. It would be nice if the icon has a dark background as the other icons in the top bar.

avatar brianteeman
brianteeman - comment - 4 Mar 2022

Sorry I have no idea why that icon is being used

avatar pritam825
pritam825 - comment - 6 Mar 2022

I have tested this item successfully on 49c703b

Working As Expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37183.

avatar pritam825 pritam825 - test_item - 6 Mar 2022 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 6 Mar 2022

The real question is does Joomla really need this? All it does is remove a single click (to open the existing menu) but yet takes up a considerable amount of pixels in an already crowded (and 3pd already using) toolbar - and it cannot be disabled.

The correct implementation would be for the User Menu to be a real menu, controlled by Joomla Menus Component, that items can be added/removed from, and for this button to be implemented as a new module that could be enabled, positioned, and disabled at the will of the admin.

Hard coding these changes in the way these several PR's suggest, is a backward step.

avatar chmst
chmst - comment - 6 Mar 2022

Fully agree

@PhilETaylor The correct implementation would be for the User Menu to be a real menu, controlled by Joomla Menus Component, that items can be added/removed from, and for this button to be implemented as a new module that could be enabled, positioned, and disabled at the will of the admin.

For the moment this could be a quick reminder for users to log out.

avatar brianteeman
brianteeman - comment - 6 Mar 2022

For the moment this could be a quick reminder for users to log out.

But not an action that is really needed

avatar PhilETaylor
PhilETaylor - comment - 6 Mar 2022

For the moment this could be a quick reminder for users to log out.

It is actually more secure to stay logged in. This is why GitHub and other major web applications have a long long session time and you very very rarely have to login again. The days of reminding people to logout and close their browser are history.

avatar Shubhamverma2796
Shubhamverma2796 - comment - 7 Mar 2022

So should I close this pr?

avatar ChristineWk
ChristineWk - comment - 7 Mar 2022

You are both right. But test itself is successful with nice button.
<span class="icon-exit icon-fw" aria-hidden="true"></span>


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37183.

avatar ChristineWk
ChristineWk - comment - 7 Mar 2022

I have tested this item successfully on 453e34b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37183.

avatar ChristineWk ChristineWk - test_item - 7 Mar 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Mar 2022

@chmst did some research into the icon. It would seem that a lot of places dont find the exit door icon clear as it is rarely used. Most places just use the text. Even fontawesome themselves cant find it an obvious icon to use as they have included text on their own ite

image

avatar chmst
chmst - comment - 7 Mar 2022

@brianteeman I have apps where this icon is used, and found it very clear. But I don't insist here, I have no statistics or studies how users understand this icon.

grafik

In general I think that a text + icon would be great, in an extra module, i really like this idea.
But then the personal settings of the user should be removed from the top bar and go to the left menu.

We could keep this nice idea as a feature request for further improvement?

avatar brianteeman
brianteeman - comment - 7 Mar 2022

for me personally I dont like this little button. I hit it a few times today with my fat fingers when trying to activate the user dropdown and had to log back in

avatar bembelimen
bembelimen - comment - 8 Mar 2022

Hello @Shubhamverma2796 thank you very much for your contribution. I know how much time you spend here, but after reading all the arguments and thinking about it, I have to agree that this button brings not the big benefit we hoped for. This evaluation could only have been made because of your great work, so don't feel rejected as I close this PR now. Looking forward for your next PR.

avatar bembelimen bembelimen - close - 8 Mar 2022
avatar bembelimen bembelimen - change - 8 Mar 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-03-08 10:27:31
Closed_By bembelimen
Labels Added: ?
avatar richard67
richard67 - comment - 8 Mar 2022

@bembelimen What to do with the issue #37109 ? Leave it closed without comment? Or leave some comment there? Or move it to discusssions?

avatar bembelimen
bembelimen - comment - 8 Mar 2022

As this PR is linked, isn't this enough?

avatar richard67
richard67 - comment - 8 Mar 2022

Don't know.

avatar crimle
crimle - comment - 8 Mar 2022

I am deeply disappointed with the way this PR has ended. Developers should empathize with the needs of users and not exclusively think PHP and Javascript. I have been a Joomla power user for many years (back to Joomla 1.x). I currently maintain 92 Joomla websites, 30 are on Joomla 3.10 and 62 are running Joomla 4.1.

What bothers me about Joomla 4 is the increasing number of mouseclicks that are needed for simple commands like «Log out» or «Save as copy» or «Save & New». Even the «Trash» command has been hidden behind an action button.

I am logging in and logging out several times a day. Joomla 3 had a one-click logout button at the bottom of the screen. With Joomla 4 I need to click the user menu, then move the mouse down a couple of inches, then click again. Together with the additional mouseclicks working with articles and the many additional mouseclicks Windows 11 demands, this is awkward and is tending to cause a tendinitis to my right arm.

So I am going to do now a backend template override for my 92 websites. But from the usability point of view, it should be the objective of any modern app to provide an as comfortable and easy handling as possible.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37183.

avatar crimle
crimle - comment - 8 Mar 2022

I am deeply disappointed with the way this PR has ended. Developers should empathize with the needs of users and not exclusively think PHP and Javascript. I have been a Joomla power user for many years (back to Joomla 1.x). I currently maintain 92 Joomla websites, 30 are on Joomla 3.10 and 62 are running Joomla 4.1.

What bothers me about Joomla 4 is the increasing number of mouseclicks that are needed for simple commands like «Log out» or «Save as copy» or «Save & New». Even the «Trash» command has been hidden behind an action button.

I am logging in and logging out several times a day. Joomla 3 had a one-click logout button at the bottom of the screen. With Joomla 4 I need to click the user menu, then move the mouse down a couple of inches, then click again. Together with the additional mouseclicks working with articles and the many additional mouseclicks Windows 11 demands, this is awkward and is tending to cause a tendinitis to my right arm.

So I am going to do now a backend template override for my 92 websites. But from the usability point of view, it should be the objective of any modern app to provide an as comfortable and easy handling as possible.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37183.

avatar Shubhamverma2796
Shubhamverma2796 - comment - 8 Mar 2022

First of all, it's not at all discouraging. I'm here to learn and contribute, so closing a pr is not a big deal. And, I totally agree with the #37183 (comment) because I encountered the same issue today, got logged out by mistake because of the button. But still, I believe that the log-out button should be implemented in such a way that it is clearly and directly visible to the end-user, instead of forcing the user to click unnecessarily.

avatar pritam825
pritam825 - comment - 8 Mar 2022

@Shubhamverma2796 can't we do like, when we will click on the logout button it will show the alert , are you sure want to logout, like the Facebook used for logout, so that user will see easily logout button and because of alert it won't create the problem like the brainteeman faced

avatar Shubhamverma2796
Shubhamverma2796 - comment - 8 Mar 2022

@Shubhamverma2796 can't we do like, when we will click on the logout button it will show the alert , are you sure want to logout, like the Facebook used for logout, so that user will see easily logout button and because of alert it won't create the problem like the brainteeman faced

sounds good to me. But still the number of click remains the same 😅

avatar richard67
richard67 - comment - 8 Mar 2022

So there would be again 2 clicks necessary like without any of these PRs. So where would be the advantage then?

avatar pritam825
pritam825 - comment - 8 Mar 2022

User can easily see the logout button

avatar pritam825
pritam825 - comment - 8 Mar 2022

The advantage would be that the logout button is visible directly. When I first used joomla it took me few minutes to find the logout button

avatar brianteeman
brianteeman - comment - 8 Mar 2022

There is no need to log out

Add a Comment

Login with GitHub to post a comment