I disagree with this. I think we should always look to raw javascript instead of jQuery if we can

Read the tracker item and you'll see why this is being proposed. It's not necessarily an issue with raw JS versus jQuery.

Yes. It's not an issue of raw JS vs jQuery. I think the real issue was the absence of the a div with an identifier. To fix that you do not require to use jQuery.

You should be able to replace:

jQuery('#cloak$rand').html('');

with:

document.getElementById('cloak$rand').innerHTML = '';

And the same for the other calls.

@phproberto

And the same for the other calls

the first is fixed but i don't know the/a replacement for:

jQuery('#cloak$rand').append(...)

@zero-24
Solution:

document.getElementById('cloak$rand').innerHTML = document.getElementById('cloak$rand').innerHTML + ...

I tried on my dev site and works

Thanks @zero-24 for being so open to suggestions.

To append things to an item html you can use += :

document.getElementById('cloak$rand').innerHTML += '<\/a>';

Thanks @phproberto

It is done with zero-24@8b3d235

Worked perfect for me. Hope for a merge.

Travis fails. Can you fix that?

Can you tell us what failed as I couldn't figure out what caused the failed build.

The message according to Travis is this:

There was 1 failure:
1) JHtmlEmailTest::testCloak
Cloak e-mail with mailto link
Failed asserting that '<div id="cloak23364">JLIB_HTML_CLOAKING</div><script type='text/javascript'>
 <!--
 document.getElementById('cloak23364').innerHTML = '';
 var prefix = '&#109;a' + 'i&#108;' + '&#116;o';
 var path = 'hr' + 'ef' + '=';
 var addy23364 = '&#97;dm&#105;n' + '&#64;';
 addy23364 = addy23364 + 'j&#111;&#111;ml&#97;' + '&#46;' + '&#111;rg';
 document.getElementById('cloak23364').innerHTML += '<a ' + path + '\'' + prefix + ':' + addy23364 + '\'>';
 document.getElementById('cloak23364').innerHTML += 'addy23364';
 document.getElementById('cloak23364').innerHTML += '<\/a>';
 //-->\n </script>' contains "document.write('<a ' + path + '\'' + prefix + ':' + addy".
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/html/JHtmlEmailTest.php:32

I guess one needs to adjust the test because the JavaScript output changed.

Sorry @Bakual i don't know how to fix it.

Neither do I
Maybe @wilsonge can have a look if he has time?

Why have I suddenly become the unit test expert hides. Ummm I'll try and have a look but I'm so busy at the moment not sure when that will be. I don't think it will be that hard to do so it just depends when I get a free hour.

OK change this https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/cms/html/JHtmlEmailTest.php#L30

from
$this->StringContains("document.write('<a ' + path + '\'' + prefix + ':' + addy"),
to
$this->StringContains(".innerHTML += '<a ' + path + '\'' + prefix + ':' + addy23364 + '\'>'"),

Why have I suddenly become the unit test expert

In german we have a saying "Among the blind the one-eyed is king"

thanks @wilsonge

zero-24@a73e217

Tested. Works as expected!

Works for me too

Travis still fails

Maybe try with $this->StringContains(".innerHTML += '<a ' + path + '\'' + prefix + ':' + addy"),
Since the number is random, we need to stop using this in the assertion and we can't use anything behind it.

merged @Bakual zero-24@51e0189

Travis fine now. Thanks all!

thanks @wilsonge @Bakual @laoneo @losedk @fdesanto @phproberto @mbabker

Great work. Will it be in the next Joomla release? Need to tell it my users as some are suffering from this bug. Will it be backported to Joomla 2.5?

It will be in the next release, yes.
We could backport it to 2.5 if someone wants to do a PR against the 2.5.x branch.

I was just code reviewing this for a 2.5 backport and we've lost the open script tag in this PR. Yet we still have a close script tag. Seems dodgy.......

There is a opening script tag?

$replacement = '<div id="cloak' . $rand . '">' . JText::_('JLIB_HTML_CLOAKING') . '</div>' . "<script type='text/javascript'>";

facepalm

:D

#3885 backport PR if you want to test...

Folks, I have issues with this: it breaks a link like:

été

The reason is that the text contains utf8 characters as everything is OK when using

ete

Doesn't look like related to this change. I've tried on an older test site and it also behaves like this there.

I have reverted this and it works normally

I also have issues when using for example:

<p>ete@mysite.com</p>

reverting this PR solves all

but yes, after reverting the mail with été is also broken

I noticed that the opening comment for all of the Javascript tags are not commented out (especially on the Travis build error listed earlier). Shouldn't they be commented?

Merged #3914
remains an issue when adding an email to an image:
The link works fine but the image does not display anymore:

I have a solution. Preparing patch

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33957&start=0

#3915