No Code Attached Yet
avatar brianteeman
brianteeman
27 Feb 2022

Can someone please check that this is working as intended. It might be me doing something wrong but I am expecting that when running then any changes I make to an scss file inside build\media_source\templates\ will be converted to css, copied to \media and minified.

Is it broken or is my expectation wrong?

avatar brianteeman brianteeman - open - 27 Feb 2022
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 27 Feb 2022
avatar dgrammatiko
dgrammatiko - comment - 27 Feb 2022

@brianteeman the watch is only aware of the entry SCSS file at the moment, so if you edit an import that won't kick a new rebuild. It should be easily fixable if someone could add this file in the mix: https://github.com/sass/node-sass/blob/master/lib/watcher.js

avatar akshitrattan
akshitrattan - comment - 17 Mar 2022

will simply adding the watcher.js file in the build folder and making changes in the package.json file work??

avatar akshitrattan
akshitrattan - comment - 18 Mar 2022

@brianteeman the watch is only aware of the entry SCSS file at the moment, so if you edit an import that won't kick a new rebuild. It should be easily fixable if someone could add this file in the mix: https://github.com/sass/node-sass/blob/master/lib/watcher.js

I feel I've I'm close to solving this problem but while trying to implement the solution the 'this.reset() is giving an error and I cannot figure out why

avatar dgrammatiko
dgrammatiko - comment - 18 Mar 2022

the 'this.reset() is giving an error and I cannot figure out why

What is the error you're getting?

avatar akshitrattan
akshitrattan - comment - 18 Mar 2022

im using the 'changed' function in the watcher.js file to watch for changes in SASS files, the function consists of a line "this.reset()" which itself is another function, but while running the watch command in the terminal it gives an error that 'this.reset()" is not a function
Screenshot 2022-03-18 at 7 41 05 PM

avatar dgrammatiko
dgrammatiko - comment - 18 Mar 2022

@akshitrattan do you have a link to the brach you're currently working?

avatar akshitrattan
akshitrattan - comment - 18 Mar 2022

@akshitrattan do you have a link to the brach you're currently working?

https://github.com/akshitrattan/joomla-cms/tree/Fix%2337155

avatar brianteeman brianteeman - change - 9 Aug 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-08-09 15:48:11
Closed_By brianteeman
avatar brianteeman brianteeman - close - 9 Aug 2022

Add a Comment

Login with GitHub to post a comment