? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
26 Feb 2022

Pull Request for Issue # .

Summary of Changes

This pull request (PR) fixes the next sequence values in PostgreSQL installation SQL scripts which have been forgotten to change when new records for the task scheduler were added with PR #35143 .

Some more wrong values from that PR e.g. for the assets table have already been fixed by someone with some other PR.

Testing Instructions

Code review by someone who knows how sequences work on PostgreSQL, or make a new installation using a PostgreSQL database and then try to insert new records into tables "#__action_logs_extensions" or "#__action_log_config".

Actual result BEFORE applying this Pull Request

Inserting a new record fails with error about duplicate primary key, e.g.:

ERROR: duplicate key value violates unique constraint "j4ux0_action_logs_extensions_pkey" DETAIL: Key (id)=(19) already exists.

Expected result AFTER applying this Pull Request

Inserting a new record works, and the new ID has the right value.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 26 Feb 2022
avatar richard67 richard67 - change - 26 Feb 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2022
Category Postgresql SQL Installation
avatar roland-d
roland-d - comment - 26 Feb 2022

@richard67 This looks good to me.

avatar alikon alikon - test_item - 27 Feb 2022 - Tested successfully
avatar alikon
alikon - comment - 27 Feb 2022

I have tested this item successfully on 6187512


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37154.

avatar roland-d
roland-d - comment - 27 Feb 2022

I have tested this item successfully on 6187512

Looks good to me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37154.

avatar roland-d roland-d - test_item - 27 Feb 2022 - Tested successfully
avatar richard67 richard67 - change - 27 Feb 2022
Labels Added: ?
avatar richard67 richard67 - edited - 27 Feb 2022
avatar richard67
richard67 - comment - 27 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37154.

avatar richard67 richard67 - change - 27 Feb 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 27 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37154.

avatar wilsonge wilsonge - close - 27 Feb 2022
avatar wilsonge wilsonge - merge - 27 Feb 2022
avatar wilsonge wilsonge - change - 27 Feb 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-02-27 23:25:01
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 27 Feb 2022

Thanks!

avatar richard67
richard67 - comment - 28 Feb 2022

@wilsonge Do you think it could need some update SQL script to fix wrong sequences on update?

avatar wilsonge
wilsonge - comment - 28 Feb 2022

I'm not sure. Obviously in an ideal world yes - but given it affects all existing sites not sure whether it's going to cause more pain that it's worth?

Add a Comment

Login with GitHub to post a comment