No Code Attached Yet
avatar dyfrig
dyfrig
15 Feb 2022

The system plugin Joomla Accessibility Checker needs to be changed so that the following language constants cater for languages with multiple plurals

PLG_SYSTEM_JOOA11Y_PANEL_STATUS_2="1 accessibility error and %(warningCount) warnings found."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_3="%(errorCount) accessibility errors and 1 warning found."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_4="%(errorCount) accessibility errors and %(warningCount) warnings found."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_6="%(errorCount) accessibility errors found."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_8="Please review %(warningCount) warnings."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_10="%(warningCount) <span class="jooa11y-visually-hidden">warnings found."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_11="%(totalCount) <span class="jooa11y-visually-hidden">total issues found."

avatar dyfrig dyfrig - open - 15 Feb 2022
avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Feb 2022
avatar brianteeman
brianteeman - comment - 15 Feb 2022

I'm not sure if that is solvable. Could you create an issue on the jooa11y main tracker please https://github.com/joomla-projects/joomla-a11y-checker/issues

avatar Kostelano
Kostelano - comment - 15 Feb 2022

@dyfrig Make it easier. For example, how we did it for the Russian language, since we also have enough forms of pluralization.

https://github.com/JPathRu/localisation/blob/joomla-4/administrator/language/ru-RU/plg_system_jooa11y.ini#L51

avatar infograf768
infograf768 - comment - 16 Feb 2022

never use a _figure=" when it is NOT a plural form!!!

Rather use for example
PLG_SYSTEM_JOOA11Y_PANEL_2_STATUS="1 accessibility error and %(warningCount) warnings found."

avatar dyfrig
dyfrig - comment - 16 Feb 2022

I would suggest combining Kostelano's and Infograf768's suggestions into to avoid both problems. Not sure if it would work for all languages but it would for Welsh and, according to Kostelano for Russian. This would result in something like

;Panel status
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_1_MESSAGE="Accessibility errors: 1, Warnings: 1"
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_10_MESSAGE="<span class="jooa11y-visually-hidden">Warnings found: %(warningCount)"
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_11_MESSAGE="<span class="jooa11y-visually-hidden">total issues found: %(totalCount)"
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_2_MESSAGE="Accessibility errors: 1, Warnings: %(warningCount)"
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_3_MESSAGE="Accessibility errors: %(errorCount), Warnings: 1"
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_4_MESSAGE="Accessibility errors: %(errorCount), Warnings: %(warningCount)"
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_5_MESSAGE="Accessibility errors: 1"
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_6_MESSAGE="Accessibility errors: %(errorCount)"
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_7_MESSAGE="Please review warning."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_8_MESSAGE="Please review warnings [%(warningCount)]."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_9_MESSAGE="No accessibility errors found."
PLG_SYSTEM_JOOA11Y_PANEL_STATUS_12_MESSAGE="The item you are trying to view is not visible; it may be hidden or inside of an accordion or tab component. Here's a preview="

avatar dyfrig
dyfrig - comment - 16 Feb 2022

I'm not sure if that is solvable. Could you create an issue on the jooa11y main tracker please https://github.com/joomla-projects/joomla-a11y-checker/issues

Done joomla-projects/joomla-a11y-checker#66

avatar brianteeman
brianteeman - comment - 16 Feb 2022

As this will require changes upstream first and as @dyfrig has created an issue there can this be closed here.

avatar dyfrig
dyfrig - comment - 16 Feb 2022

Closing the issue as the upstream includes both original issue and Infograf768's comments.

avatar dyfrig dyfrig - change - 16 Feb 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-02-16 12:45:49
Closed_By dyfrig
avatar dyfrig dyfrig - close - 16 Feb 2022

Add a Comment

Login with GitHub to post a comment