[#36995] - Formatted the calendar widget
- Closed
- 20 Jun 2023
- Medium
- Build: 4.1-dev
- # 36995
- Diff
- akshitrattan:Fix#36933
User tests: Successful: Unsuccessful:
Pull Request for Issue #36933 .
Summary of Changes
solved issue number 3/3.
Stylized the time drop-down menu according to bootstrap 4 and centred the calendar table in the widget for the calendar to look more symmetrical
Testing Instructions
Open the calendar widget in any of the tabs you wish to, notice the change in the buttons from the previous versions
Actual result BEFORE applying this Pull Request
calendar looked like this
Expected result AFTER applying this Pull Request
it should look like this
Documentation Changes Required
No changes required
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change JavaScript |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
?
|
||
This pull requests has been automatically converted to the PSR-12 coding standard.
I have tested this item
Looks good for me. Especially in languages with longer words.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36995.
| Labels |
Added:
?
Removed: ? |
||
This pull request has been automatically rebased to 4.3-dev.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36995.
I have tested this item
Just find your PR, while i've done one to improve calendar form field datetime picker #40761
I've set my test as unsuccessfully, as the colspan changes may have issues depending on the form field settings (with or without weeknumbers, am/pm...)
And the css changes are not flexible to work in different cases (language, settings...).
You can check my PR #40761 and see what i did there (with a bit more styling for other elements, such as footer buttons) ;-)
Thanks!
Cyril
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36995.
Thank you Akshit @akshitrattan for this PR. After review, I think this is not flexible enough and results may vary depending on the languages used. I am closing the PR in favor of PR #40761.
Thank you for your contribution on this!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-20 15:22:50 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
bug
PR-4.3-dev
?
Removed: ? |
||
This pull request has automatically rebased to 4.2-dev.