[#36932] - [4.2] Consider permissions for MM actions
- Fixed in Code Base
- 13 Feb 2022
- Medium
- Build: 4.2-dev
- # 36932
- Diff
- Digital-Peak:j4/media/icons-permissions
User tests: Successful: Unsuccessful:
Pull Request for Issue #36549.
Summary of Changes
Passes the global permissions from the media manager to the client app. The item can define a flag as well to specify if the item itself can be edited/deleted. This allows external adapters to define also per item permissions.
This pr is based on the pr from @dgrammatiko and #36556.
Testing Instructions
- Check the instructions in issue #36549.
- Additionally add a canEdit/canDelete flag to the file /plugins/filesystem/local/src/Adapter/LocalAdapter.php on line 344.
Actual result BEFORE applying this Pull Request
Actions are always shown.
Expected result AFTER applying this Pull Request
Actions are only shown when the permissions are correct.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
Did you do npm ci? As this is something which is handled in the actionItemsContainer.vue file.
Tested with the prebuilt package so no need to npm ci.
Was a copy paste error, can you test again?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36932.
Don't know if this is beyond the scope or not. But when you have edit permission but there are no media plugins enabled the pencil icon is still displayed
Don't know if this is beyond the scope or not. But when you have edit permission but there are no media plugins enabled the pencil icon is still displayed
I would handle this is in it's own pr.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36932.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36932.
Done
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-13 15:35:21 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
|
||
Thanks everybody.
Delete permission is denied.
No delete button, however, there is a delete item action.