[#36923] - improving Menus: Edit Item - moving Publishing fields v3 #36918
- Pending
- Medium
- Build: 4.1-dev
- # 36923
- Diff
- pe7er:feature/36918-menu-item-edit-start-finish-publishing-v3
User tests: Successful: Unsuccessful:
Pull Request for Issue #36918
This PR is against 4.1-dev and makes my earlier PR #36920 (against the 4.0-dev branch) obsolete.
Summary of Changes
This PR moves in the Menus: Edit Item the Start Publishing and Finish Publishing date to the bottom,
so that the Access and Language are easier to use (like in Joomla 3.x)
Testing Instructions
Actual result BEFORE applying this Pull Request
On a multilingual website, go to Menus > Main Menu (en-GB) > Create a new menu item.
You have to scroll a lot to reach the Access and Language fields:
Expected result AFTER applying this Pull Request
After the PR the Access and Language fields are easier to use because you don't have to scroll past the Start Publishing and Finish Publishing fields:
Documentation Changes Required
The screens in the documentation will have to be updated to reflect the new position of the Start Publishing and Finish Publishing date at the bottom right of the screen: https://help.joomla.org/proxy?keyref=Help4.x:Menu_Item:_New_Item/en
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
After the PR the Access and Language fields are easier to use because you don't have to scroll past the Start Publishing and Finish Publishing fields:
Instead the Start Publishing and Finish Publishing fields are harder to use as you have to scroll past the access and language fields.
We really should be doing real testing before making changes
I had some issues with git and the Joomla branches on my local system. So I checked out a crispy fresh 4.1-dev branch to redo my small patch. I didn't know the rebase function in Github. Thanks @brianteeman !
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36923.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36923.
I think the position of publish up/down is wrong at all...we should stick with out standard we have in e.g. articles and have it in the correct follow up tabs. (Also for other fields which are everywhere)
@bembelimen are you suggesting an extra tab "Publishing" in the menu item with these options?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36923.
@bembelimen are you suggesting an extra tab "Publishing" in the menu item with these options?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36923.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36923.
See the comment from @bembelimen this PR is not thee correct solution
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. @bembelimen can you decide on this issue?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36923.
Like I said, it should be streamlined with the other implementation we have in core already
Like I said, it should be streamlined with the other implementation we have in core already
except modules also have this on the first tab as well. So we're not consistent there either
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
Documentation Required
?
?
?
|
||
As @bembelimen wrote, changes in global parts of our edit screen are against a11y and UX.
For future reference if you are asked to rebase a pr you do not need to close it and make a new one.